Last Comment Bug 757847 - CompositorParent::TransformShadowTree should use FrameMetrics& instead of FrameMetrics*
: CompositorParent::TransformShadowTree should use FrameMetrics& instead of Fra...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: Other Other
: -- normal (vote)
: mozilla15
Assigned To: Kartikaya Gupta (email:kats@mozilla.com)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-23 07:48 PDT by Kartikaya Gupta (email:kats@mozilla.com)
Modified: 2012-05-24 09:25 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (4.79 KB, patch)
2012-05-23 08:15 PDT, Kartikaya Gupta (email:kats@mozilla.com)
ajuma.bugzilla: review+
Details | Diff | Review

Description Kartikaya Gupta (email:kats@mozilla.com) 2012-05-23 07:48:57 PDT
See https://bugzilla.mozilla.org/show_bug.cgi?id=748384#c40 - :mats pointed out that TransformShadowTree uses a FrameMetrics* and does null checks when it could just be using a FrameMetrics& and skip the null checks.
Comment 1 Kartikaya Gupta (email:kats@mozilla.com) 2012-05-23 08:15:15 PDT
Created attachment 626453 [details] [diff] [review]
Patch
Comment 2 Kartikaya Gupta (email:kats@mozilla.com) 2012-05-23 18:57:19 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/84db28a553ac
Comment 3 Ed Morley [:emorley] 2012-05-24 09:25:12 PDT
https://hg.mozilla.org/mozilla-central/rev/84db28a553ac

Note You need to log in before you can comment on or make changes to this bug.