Load JS HTTP server as a module

RESOLVED FIXED in mozilla16

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 626460 [details] [diff] [review]
Refactor test code to load JS HTTP server as a module

Queued storage server and AITC server patches will require the JS HTTP server to be loaded as a module because those things are themselves being implemented as testing-only JS modules.

This can't be checked in until bug 755196, bug 755339, and bug 757460 all land.
Attachment #626460 - Flags: review?(rnewman)
Comment on attachment 626460 [details] [diff] [review]
Refactor test code to load JS HTTP server as a module

Review of attachment 626460 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sane to me.
Attachment #626460 - Flags: review?(rnewman) → review+
(Assignee)

Updated

6 years ago
No longer blocks: 744323
(Assignee)

Updated

6 years ago
No longer blocks: 749336
(Assignee)

Comment 2

6 years ago
Created attachment 629166 [details] [diff] [review]
Refactor code to load JS HTTP server as a module

This is what the new patch looks like. The end state is the same as what was previously reviewed. The diff just looks nastier because of the order the patches needed to land in.
Assignee: nobody → gps
Attachment #626460 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #629166 - Flags: review+
(Assignee)

Updated

6 years ago
Blocks: 760466
Whiteboard: [qa+]
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/services/services-central/rev/ea5eedb6ff46
Whiteboard: [qa+] → [qa+][fixed in services]
Target Milestone: --- → mozilla16
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/ea5eedb6ff46
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa+][fixed in services] → [qa+]
You need to log in before you can comment on or make changes to this bug.