Closed Bug 757860 Opened 8 years ago Closed 8 years ago

Load JS HTTP server as a module

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: gps, Assigned: gps)

References

Details

(Whiteboard: [qa+])

Attachments

(1 file, 1 obsolete file)

Queued storage server and AITC server patches will require the JS HTTP server to be loaded as a module because those things are themselves being implemented as testing-only JS modules.

This can't be checked in until bug 755196, bug 755339, and bug 757460 all land.
Attachment #626460 - Flags: review?(rnewman)
Comment on attachment 626460 [details] [diff] [review]
Refactor test code to load JS HTTP server as a module

Review of attachment 626460 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sane to me.
Attachment #626460 - Flags: review?(rnewman) → review+
No longer blocks: 744323
No longer blocks: 749336
This is what the new patch looks like. The end state is the same as what was previously reviewed. The diff just looks nastier because of the order the patches needed to land in.
Assignee: nobody → gps
Attachment #626460 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #629166 - Flags: review+
Blocks: 760466
Whiteboard: [qa+]
https://hg.mozilla.org/services/services-central/rev/ea5eedb6ff46
Whiteboard: [qa+] → [qa+][fixed in services]
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/ea5eedb6ff46
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [qa+][fixed in services] → [qa+]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.