757893 - unable to pinch zoom out after switching tabs and back

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

Attachment: logcat

I am unable to pinch zoom back out when first zooming into a page, switching a tab, and then switching back to the previous tab state.   Trying to pinch zoom out is stuck.

See screencast: http://youtu.be/7ARd9J1f6XY.   Skip to the end to see what i'm talking about.

Also attaching logcat, although i didnt see any errors thrown.

REpro:
1) install 5-23-2012 nightly, HTC Sensation, Android 2.3.4
2) visit site and pinch zoom into text area:  http://www.cnn.com/2012/05/23/opinion/blank-facebook-ipo/index.html?hpt=hp_t1
3) switch tabs to something else (eg. huffingtonpost.com)
4) switch back to the previous tab, and notice site should still be zoomed in from last state
5) try pinch zooming back out.   Verify its not doing it

Expected:
- switch tabs and able to zoom back out

Actual:
- switching tabs and back, zooming back out is broken

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hmm, I couldn't reproduce this, but after switching back to the tab I noticed that pinch zooming out was slower (it was zooming out less for the same finger movement than right after I zoomed in).

And then I accidentally tapped on a few links and clicked back, and ended up reproducing something that looks a lot like bug 748509 :(

Comment 2

[Wesley Johnston (:wesj)]

I'm guessing this is related to page with user-scalable=false set. Digging a bit more....

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Here's some more detailed STR for the first part (slow zooming):

1. Open up the CNN page in a new tab
2. double-tap the search text field in the upper right
3. switch to a different tab
4. switch back to CNN
5. notice that if you pinch from the corners of the screen all the way in, it looks like nothing is happening -- we're zooming a very small amount.  if you keep doing it, eventually you'll zoom all the way back out.

If, once the page is fully zoomed out, you zoom in and then zoom out, zooming out shuold be fast (pinch from middle to edges gets you very close, and the opposite will get you back to the original zoom).

Comment 4

[Wesley Johnston (:wesj)]

We're not reseting minZoom and maxZoom when you switch tabs. Testing a patch....

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch

Fixes this for me. Maybe we want to just use the tab as the sole source of truth though....

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 626574 [details] [diff] [review]
Patch

Review of attachment 626574 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01c405adc966

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 626574 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 707571
User impact if declined: Switching between tabs can result in pages that are at the wrong scale and that can't be scaled (or the opposite, pages that should be unscalable would end up at the wrong scale and allow pinch zoom). I believe loading a new page resets min and max zoom so they should work again.
Testing completed (on m-c, etc.): Landed on MC May 24.
Risk to taking this patch (and alternatives if risky): Low risk. At worst, we're doing redundant work setting the zoom to what it should be.
String or UUID changes made by this patch: None.

Comment 9

[Alex Keybl [:akeybl]]

This needs to land asap on MOBILE140_2012052310_RELBRANCH as well as tip of mozilla-aurora to minimize the code change between what QA has already been testing and what we'll actually release this week.

Comment 10

[Wesley Johnston (:wesj)]

MOBILE140_2012052310_RELBRANCH
https://hg.mozilla.org/releases/mozilla-aurora/rev/fcd3d27d53c6

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0895715508d

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

qa wanted : verification needed.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Seems to work for the Aurora TB Build : https://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-aurora-android/1337887976/

Comment 14

[Adrian Tamas (:AdrianT)]

I am unable to reproduce the issue on Firefox 14.0b3 build 2 but I am able to reproduce the issue on Aurora 14.0a2 2012-05-24 on HTC Desire Z running Android 2.3.3.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

(In reply to adrian tamas from comment #14)
> I am able
> to reproduce the issue on Aurora 14.0a2 2012-05-24 on HTC Desire Z running
> Android 2.3.3.

That build doesn't have the fix.

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/01c405adc966

Comment 17

[Tony Chung [:tchung]]

Verified fix on fx14 beta 3

Comment 18

[Tony Chung [:tchung]]

Verified fixed on 5-30-2012 nightly.