757937 - checkboxes and radio buttons are extremely small

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. Go to http://people.mozilla.com/~nhirata/html_tp/formsninput.html
2. look at the radio/checkbox buttons with medium Text Size
3. try tapping on the buttons

Expected: they should be easily selectable and viewable
Actual: the boxes and checkboxes are so small, makes it hard to tap.

Regression from bug 706889; if the checkboxes/radio buttons get bigger, then the tap target areas get bigger (bug 753250)

Comment 1

[Johnathan Nightingale [:johnath]]

Discussed in triage - assigning to dbaron because it looks like something broke his fixes in bug 706889

Comment 2

[Adrian Tamas (:AdrianT)]

I am seeing the issue also on HTC Desire running Android 2.2 and HTC Desire Z running Android 2.3.3 - Changing the title to cover all phones. Will try to find the regression range.

Comment 3

[Adrian Tamas (:AdrianT)]

good build: May 5th 2012
bad build: May 6th 2012

regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0a48e6561534&tochange=94ce5f33a9ea

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This can be tested on desktop by setting the "mozilla.widget.disable-native-theme" preference to true.

On desktop, I get an entirely different regression range from 64-bit Linux nightlies, though:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=364f0a5a1d2d&tochange=0d871550085e

This, frankly, contains a much more likely candidate for causing the regression:
http://hg.mozilla.org/mozilla-central/rev/1587faab5e5c

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22a1bfac13d6 though I should also really add a test

Comment 7

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/mozilla-central/rev/22a1bfac13d6

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 628148 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 708175
User impact if declined: radio buttons and checkboxes are much smaller than text, since they're not inflated
Testing completed (on m-c, etc.): on mozilla-central 
Risk to taking this patch (and alternatives if risky):  relatively low risk; very slight risk that somebody was depending on the default GetType() result, but that seems very unlikely
String or UUID changes made by this patch: none

Comment 9

[Jet Villegas (inactive)]

Need FF14 (beta) uplift on this one.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f7541054a7b8
https://hg.mozilla.org/releases/mozilla-beta/rev/78152b1a7298

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out of Aurora due to perma-orange on Linux PGO Moth.

https://hg.mozilla.org/releases/mozilla-aurora/rev/5838fc84511b

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

relanded successfully
https://hg.mozilla.org/releases/mozilla-aurora/rev/5f08078c0af9

Comment 13

[Catalin Suciu [:csuciu]]

Verified fixed using http://people.mozilla.com/~nhirata/html_tp/formsninput.html on:
Nightly 16.0a1 (2012-06-12)
Aurora  15.0a2 (2012-06-12)

Samsung Galaxy SII (2.3.4)

Still needs to be verified on next beta build.

Comment 14

[Adrian Tamas (:AdrianT)]

Verified fixed on:
Aurora 15.0a2 2012-07-08/Nightly 16.0a1 2012-07-08/ Firefox Mobile 14.0b11
HTC Desire/Samsung Google Nexus
Android 2.2.2/ Android 4.0.2