Closed Bug 757937 Opened 8 years ago Closed 8 years ago

checkboxes and radio buttons are extremely small

Categories

(Firefox for Android :: General, defect)

14 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 16
Tracking Status
firefox14 --- verified
firefox15 --- verified
blocking-fennec1.0 --- +

People

(Reporter: nhirata, Assigned: dbaron)

References

()

Details

(Keywords: regression, Whiteboard: [readability])

Attachments

(2 files)

Attached image screenshot
1. Go to http://people.mozilla.com/~nhirata/html_tp/formsninput.html
2. look at the radio/checkbox buttons with medium Text Size
3. try tapping on the buttons

Expected: they should be easily selectable and viewable
Actual: the boxes and checkboxes are so small, makes it hard to tap.

Regression from bug 706889; if the checkboxes/radio buttons get bigger, then the tap target areas get bigger (bug 753250)
Discussed in triage - assigning to dbaron because it looks like something broke his fixes in bug 706889
Assignee: nobody → dbaron
blocking-fennec1.0: ? → +
Whiteboard: [readability]
I am seeing the issue also on HTC Desire running Android 2.2 and HTC Desire Z running Android 2.3.3 - Changing the title to cover all phones. Will try to find the regression range.
Summary: checkboxes and radio buttons are extremely small on the Galaxy S II → checkboxes and radio buttons are extremely small
This can be tested on desktop by setting the "mozilla.widget.disable-native-theme" preference to true.

On desktop, I get an entirely different regression range from 64-bit Linux nightlies, though:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=364f0a5a1d2d&tochange=0d871550085e

This, frankly, contains a much more likely candidate for causing the regression:
http://hg.mozilla.org/mozilla-central/rev/1587faab5e5c
Attached patch patchSplinter Review
Attachment #628148 - Flags: review?(sjohnson)
Attachment #628148 - Flags: review?(sjohnson) → review?(roc)
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/22a1bfac13d6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 628148 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 708175
User impact if declined: radio buttons and checkboxes are much smaller than text, since they're not inflated
Testing completed (on m-c, etc.): on mozilla-central 
Risk to taking this patch (and alternatives if risky):  relatively low risk; very slight risk that somebody was depending on the default GetType() result, but that seems very unlikely
String or UUID changes made by this patch: none
Attachment #628148 - Flags: approval-mozilla-beta?
Attachment #628148 - Flags: approval-mozilla-aurora?
Attachment #628148 - Flags: approval-mozilla-beta?
Attachment #628148 - Flags: approval-mozilla-beta+
Attachment #628148 - Flags: approval-mozilla-aurora?
Attachment #628148 - Flags: approval-mozilla-aurora+
Need FF14 (beta) uplift on this one.
Verified fixed using http://people.mozilla.com/~nhirata/html_tp/formsninput.html on:
Nightly 16.0a1 (2012-06-12)
Aurora  15.0a2 (2012-06-12)

Samsung Galaxy SII (2.3.4)

Still needs to be verified on next beta build.
Verified fixed on:
Aurora 15.0a2 2012-07-08/Nightly 16.0a1 2012-07-08/ Firefox Mobile 14.0b11
HTC Desire/Samsung Google Nexus
Android 2.2.2/ Android 4.0.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.