Can't open the page context menu when inspecting (highlighter = unlocked) on Windows.

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Johan C, Assigned: Johan C)

Tracking

unspecified
Firefox 15
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 626535 [details] [diff] [review]
patch 0.1

When the highlighter is unlocked, it is not possible to open the page context menu (right click) on Windows.
Attachment #626535 - Flags: review?(paul)
(Assignee)

Updated

5 years ago
Assignee: nobody → johan.charlez
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 626568 [details] [diff] [review]
patch 0.2

Added proposed fix for the "TypeError: aDocument is null" exception, which is thrown when the highlighter is unlocked and you (hold down) middle click and move the pointer to scroll the page.
Attachment #626535 - Attachment is obsolete: true
Attachment #626535 - Flags: review?(paul)
Attachment #626568 - Flags: feedback?(paul)
(Assignee)

Comment 2

5 years ago
Created attachment 626570 [details] [diff] [review]
patch 0.2.1

argh, forgot to refresh
Attachment #626568 - Attachment is obsolete: true
Attachment #626568 - Flags: feedback?(paul)
Attachment #626570 - Flags: feedback?(paul)

Comment 3

5 years ago
(In reply to Johan Charlez from comment #2)
> Created attachment 626570 [details] [diff] [review]
> patch 0.2.1
> 
> argh, forgot to refresh

How comes aEvent.target.ownerDocument can be null?

Comment 4

5 years ago
Johan explained on IRC that we run into a null ownerDocument when the target element is part of the Chrome.

Comment 5

5 years ago
Comment on attachment 626570 [details] [diff] [review]
patch 0.2.1

r+ if you can confirm that all the tests pass.
Attachment #626570 - Flags: feedback?(paul) → review+
(Assignee)

Comment 6

5 years ago
(In reply to Paul Rouget [:paul] from comment #5)
> Comment on attachment 626570 [details] [diff] [review]
> patch 0.2.1
> 
> r+ if you can confirm that all the tests pass.

All tests in TEST_PATH=browser/devtools/highlighter/test/ pass.
Whiteboard: [land-in-fx-team]

Comment 7

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/07b976407985
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/07b976407985
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.