Last Comment Bug 757945 - Can't open the page context menu when inspecting (highlighter = unlocked) on Windows.
: Can't open the page context menu when inspecting (highlighter = unlocked) on ...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: unspecified
: All Windows 7
: -- normal (vote)
: Firefox 15
Assigned To: Johan C
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-23 12:00 PDT by Johan C
Modified: 2012-05-31 01:57 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 0.1 (1000 bytes, patch)
2012-05-23 12:00 PDT, Johan C
no flags Details | Diff | Splinter Review
patch 0.2 (1.74 KB, patch)
2012-05-23 13:06 PDT, Johan C
no flags Details | Diff | Splinter Review
patch 0.2.1 (1.72 KB, patch)
2012-05-23 13:09 PDT, Johan C
paul: review+
Details | Diff | Splinter Review

Description Johan C 2012-05-23 12:00:31 PDT
Created attachment 626535 [details] [diff] [review]
patch 0.1

When the highlighter is unlocked, it is not possible to open the page context menu (right click) on Windows.
Comment 1 Johan C 2012-05-23 13:06:34 PDT
Created attachment 626568 [details] [diff] [review]
patch 0.2

Added proposed fix for the "TypeError: aDocument is null" exception, which is thrown when the highlighter is unlocked and you (hold down) middle click and move the pointer to scroll the page.
Comment 2 Johan C 2012-05-23 13:09:19 PDT
Created attachment 626570 [details] [diff] [review]
patch 0.2.1

argh, forgot to refresh
Comment 3 Paul Rouget [:paul] 2012-05-25 15:24:15 PDT
(In reply to Johan Charlez from comment #2)
> Created attachment 626570 [details] [diff] [review]
> patch 0.2.1
> 
> argh, forgot to refresh

How comes aEvent.target.ownerDocument can be null?
Comment 4 Paul Rouget [:paul] 2012-05-28 06:43:30 PDT
Johan explained on IRC that we run into a null ownerDocument when the target element is part of the Chrome.
Comment 5 Paul Rouget [:paul] 2012-05-28 06:44:46 PDT
Comment on attachment 626570 [details] [diff] [review]
patch 0.2.1

r+ if you can confirm that all the tests pass.
Comment 6 Johan C 2012-05-28 07:01:43 PDT
(In reply to Paul Rouget [:paul] from comment #5)
> Comment on attachment 626570 [details] [diff] [review]
> patch 0.2.1
> 
> r+ if you can confirm that all the tests pass.

All tests in TEST_PATH=browser/devtools/highlighter/test/ pass.
Comment 8 Tim Taubert [:ttaubert] 2012-05-31 01:57:51 PDT
https://hg.mozilla.org/mozilla-central/rev/07b976407985

Note You need to log in before you can comment on or make changes to this bug.