Closed Bug 757945 Opened 9 years ago Closed 9 years ago

Can't open the page context menu when inspecting (highlighter = unlocked) on Windows.

Categories

(DevTools :: Inspector, defect)

All
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: johan.charlez, Assigned: johan.charlez)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch 0.1 (obsolete) — Splinter Review
When the highlighter is unlocked, it is not possible to open the page context menu (right click) on Windows.
Attachment #626535 - Flags: review?(paul)
Assignee: nobody → johan.charlez
Status: NEW → ASSIGNED
Attached patch patch 0.2 (obsolete) — Splinter Review
Added proposed fix for the "TypeError: aDocument is null" exception, which is thrown when the highlighter is unlocked and you (hold down) middle click and move the pointer to scroll the page.
Attachment #626535 - Attachment is obsolete: true
Attachment #626535 - Flags: review?(paul)
Attachment #626568 - Flags: feedback?(paul)
Attached patch patch 0.2.1Splinter Review
argh, forgot to refresh
Attachment #626568 - Attachment is obsolete: true
Attachment #626568 - Flags: feedback?(paul)
Attachment #626570 - Flags: feedback?(paul)
(In reply to Johan Charlez from comment #2)
> Created attachment 626570 [details] [diff] [review]
> patch 0.2.1
> 
> argh, forgot to refresh

How comes aEvent.target.ownerDocument can be null?
Johan explained on IRC that we run into a null ownerDocument when the target element is part of the Chrome.
Comment on attachment 626570 [details] [diff] [review]
patch 0.2.1

r+ if you can confirm that all the tests pass.
Attachment #626570 - Flags: feedback?(paul) → review+
(In reply to Paul Rouget [:paul] from comment #5)
> Comment on attachment 626570 [details] [diff] [review]
> patch 0.2.1
> 
> r+ if you can confirm that all the tests pass.

All tests in TEST_PATH=browser/devtools/highlighter/test/ pass.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/07b976407985
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/07b976407985
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.