757978 - Uninstalling Firefox leaves behind a Nightly\webapprt folder

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Brian R. Bondy [:bbondy]]

After uninstalling Firefox I still see these 2 folders:
C:\Program Files (x86)\Nightly\webapprt\
C:\Program Files (x86)\Nightly\webapprt\components

I haven't tested on other channels (I think webapps is already on Aurora too so that would probably be affected as well)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, same for Firefox 14.0a2 but there some more directories are left behind.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Henrik Skupin (:whimboo) from comment #1)
> Yes, same for Firefox 14.0a2 but there some more directories are left behind.

Webapps support was disabled in FF 14. Can you confirm that a FF Beta build is affected by this? Otherwise, only FF 15 or later will be affected.

Comment 3

[Jason Smith [:jsmith]]

Checking my beta build, this appears not happen there, given that we backed out before the merge to beta.

Comment 4

[Jason Smith [:jsmith]]

Nominating for k9o - we really should be doing a clean uninstall for when firefox is uninstalled - nothing left for webrt on uninstall.

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Investigating

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Not sure why these flags got changed when I took the bug.  Removing the tracking flag, but I can't seem to set the blocking-kilimanjaro flag back to "-"

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

There are 2 issues causing this bug:
  1) The installer is creating an empty "webapprt\components" directory in the Firefox installation dir
  2) The uninstaller is failing to remove that empty directory

It's easy enough to explicitly remove the empty dir from the uninstaller.  Now I just need to track down what's causing the dir to be created in the first place.

Comment 8

[Brian R. Bondy [:bbondy]]

Ya I think the dir shouldn't exist in the first place. I think there are files there in the staging dir but they get packaged to an JAr file.  The blank dir remains, maybe it should be removed at staging time.

See toolkit\mozapps\installer\packager.mk

Comment 9

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1 - Remove empty webapprt dir when uninstalling Firefox

This simple change removes the empty webapprt subdirectory during Firefox uninstallation.  Modifying PACK_OMNIJAR_WEBAPP_RUNTIME is an option for preventing the creation of webapprt and webapprt\components, but it might be more trouble than it is worth.

Comment 10

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 635112 [details] [diff] [review]
Patch v1 - Remove empty webapprt dir when uninstalling Firefox

Spoke offline with Robert about this.  We'll land this patch to deal with the immediate issue and file a followup to make sure that empty directories aren't included in the installer.

Comment 11

[Alex Keybl [:akeybl]]

What's the user impact here? Just want to make sure this is worth tracking, and isn't just a matter of correctness.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Alex Keybl [:akeybl] from comment #11)
> What's the user impact here? Just want to make sure this is worth tracking,
> and isn't just a matter of correctness.

I believe the impact here is just leaving two empty folders behind on an uninstall of Firefox. Tim - Can you confirm?

Comment 13

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Jason Smith [:jsmith] from comment #12)
> (In reply to Alex Keybl [:akeybl] from comment #11)
> > What's the user impact here? Just want to make sure this is worth tracking,
> > and isn't just a matter of correctness.
> 
> I believe the impact here is just leaving two empty folders behind on an
> uninstall of Firefox. Tim - Can you confirm?

That's correct

Comment 14

[Alex Keybl [:akeybl]]

Thanks - we'll track, but wouldn't block on this.

Comment 15

[Alex Keybl [:akeybl]]

If this is left unfixed after our first beta (going to build Monday/Tuesday), we'll likely untrack.

Comment 16

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Tested by installing this try build [1], verifying that the offending directories were created, then uninstalling and verifying that the offending directories were not left over.

Inbound is currently closed, but whenever it opens back up I'll land this patch.

[1] https://tbpl.mozilla.org/?tree=Try&rev=71d111bacf7d

Comment 17

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc8bc4e1bdfc

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc8bc4e1bdfc