758064 - win32 repacks fail due to badly formed command line

Status: RESOLVED WORKSFORME

(Release Engineering :: Release Automation, defect, P3)

Description

[hwine]

found in FF 13.0b5:

win32 repack logs fail trying to run command "d;\mozilla-build\python27\python.exe \e\builds\moz2_slave\rel-m-beta-w32-rpk-3\scripts\release\signing\signtool.py --cachedir \e\builds\moz2_slave\rel-m-beta-w32-rpk-3\signing_cache -t \e\builds\moz2_slave\rel-m-beta-w32-rpk-3\token -n \e\builds\moz2_slave\rel-m-beta-w32-rpk-3\nonce -c \e\builds\moz2_slave\rel-m-beta-w32-rpk-3\scripts\release\signing\host.cert -H signing1.build.scl1.mozilla.com;9120 -H signing2.build.scl1.mozilla.com;9120 -f signcode -f gpg "l10ngen/setup.exe"

Comment 1

[Aki Sasaki (not active)]

Attachment: we're guessing, but this might work

Comment 2

[Aki Sasaki (not active)]

Kind of leaning towards backing out https://bugzilla.mozilla.org/show_bug.cgi?id=743304 now.

Comment 3

[Aki Sasaki (not active)]

Attachment: back out windows portion of bug 743304

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 626632 [details] [diff] [review]
back out windows portion of bug 743304

double landed + tagged:
default: http://hg.mozilla.org/build/buildbot-configs/rev/05d8334c9465
production: http://hg.mozilla.org/build/buildbot-configs/rev/e1ebc2735ef6
tags: http://hg.mozilla.org/build/buildbot-configs/rev/1e485aca5672

Comment 5

[Aki Sasaki (not active)]

Hal: You need to update+reconfig bm13.  Hopefully the rebuild of those repacks will work at that point.

Comment 6

[hwine]

win32 repacks successful on 13.0b5

Comment 7

[Rail Aliiev [:rail]]

huh, colons are replaced by semicolons... very strange...

Comment 8

[Chris AtLee [:catlee]]

maybe msys is doing it? http://www.mingw.org/wiki/Posix_path_conversion

Comment 9

[Aki Sasaki (not active)]

I think so.

From that link:

    An argument that doesn't start with -, ", ', or @ and contains a : followed by /, :,
    or .; and a / is considered a POSIX path list. Every :-separated element is converted
    according to these rules, and the : are replaced with ;. Any / are converted to \.

The ports are also converted to ;'s :

    -H signing1.build.scl1.mozilla.com;9120

I thought about changing this to /d/mozilla-build/... but thought backing out would be safer given the importance of getting 13.0b5 out for QA.

We could also consider putting everything in quotes in MOZ_SIGN_CMD, which is currently

MOZ_SIGN_CMD=d:/mozilla-build/python27/python.exe /e/builds/moz2_slave/rel-m-beta-w32-rpk-5/scripts/release/signing/signtool.py --cachedir /e/builds/moz2_slave/rel-m-beta-w32-rpk-5/signing_cache -t /e/builds/moz2_slave/rel-m-beta-w32-rpk-5/token -n /e/builds/moz2_slave/rel-m-beta-w32-rpk-5/nonce -c /e/builds/moz2_slave/rel-m-beta-w32-rpk-5/scripts/release/signing/host.cert -H signing1.build.scl1.mozilla.com:9120 -H signing2.build.scl1.mozilla.com:9120

This will be difficult, since it's re-exported in a bash shell script:
http://hg.mozilla.org/build/tools/file/8792673bce2a/scripts/l10n/release_repacks.sh#l53

I'm tempted to defer to bug 740142 but there's gotta be a way we can fix this.

Comment 10

[Aki Sasaki (not active)]

The good repack doesn't replace the port colons with semi-colons.
So I'd say setting PYTHON26 to /d/mozilla-build/ has a good chance of working here, assuming it doesn't break anything else.

Comment 11

[Rail Aliiev [:rail]]

(In reply to Chris AtLee [:catlee] from comment #16)
> maybe msys is doing it? http://www.mingw.org/wiki/Posix_path_conversion

Reopening this and closing bug 743304.

Comment 12

[Rail Aliiev [:rail]]

Since we have switched to win64 builders and they use more fresh version of python which doesn't require PYTHON26 env variable, I'm resolving it as WFM