Closed Bug 758197 Opened 12 years ago Closed 12 years ago

The TBPL update script at |/data/genericrhel6/src/tbpl.mozilla.org/update| should output the current changeset not the tip changeset

Categories

(Developer Services :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: fox2mike)

Details

From bug 756959 comment 1:
> [root@genericadm.private.phx1 ~]#
> /data/genericrhel6/src/tbpl.mozilla.org/update cefda9fd4b40
> + date
> Wed May 23 07:48:10 PDT 2012
> + echo -e 'Updating code...'
> Updating code...
> + cd /data/genericrhel6/src/tbpl.mozilla.org/tbpl
> + hg pull
> pulling from
> http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog
> searching for changes
> no changes found
> + hg update cefda9fd4b40
> 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
> + checkretval
> + retval=0
> + [[ 0 -gt 0 ]]
> + cd /data/genericrhel6/src/tbpl.mozilla.org/tbpl
> + hg tip
> changeset:   788:e5d599c52396
> tag:         tip
> user:        Phil Ringnalda <philringnalda@gmail.com>
> date:        Wed May 16 22:18:41 2012 -0700
> summary:     Bug 756724 - Drop Firefox3.6 tree

The update script correctly updated the working directory to cefda9fd4b40, however it then used |hg tip|, which when skim reading the output, made it seem like "Bug 756724 - Drop Firefox3.6 tree" was going to be included in the push to prod.

Instead, the script should be using |hg parent|, which would have given:

$ hg parent
changeset:   787:cefda9fd4b40
user:        Ed Morley <emorley@mozilla.com>
date:        Sat May 19 11:02:57 2012 +0100
summary:     Bug 755845 - Perform an initial buildbot data import when setting up a TBPL i
nstance using Vagrant; r=rhelmer
Summary: Make the TBPL update script at /data/genericrhel6/src/tbpl.mozilla.org/update output current working directory changeset not the tip changeset → The TBPL update script at |/data/genericrhel6/src/tbpl.mozilla.org/update| should output the current changeset not the tip changeset
Done. Should -dev do the same?
Assignee: server-ops-devservices → shyam
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: The TBPL update script at |/data/genericrhel6/src/tbpl.mozilla.org/update| should output the current changeset not the tip changeset → Make the TBPL update script at /data/genericrhel6/src/tbpl.mozilla.org/update output current working directory changeset not the tip changeset
Summary: Make the TBPL update script at /data/genericrhel6/src/tbpl.mozilla.org/update output current working directory changeset not the tip changeset → The TBPL update script at |/data/genericrhel6/src/tbpl.mozilla.org/update| should output the current changeset not the tip changeset
tbpl-dev updates straight from the repo, so I'm not sure why there is a -dev update script? Philor?
Something needs to run hg pull and hg update for a site to update..and there is a script for that?
Oh sorry, I thought these were just for manual use; though makes sense that the cron job would use the same scripts. Yeah makes sense to update that one as well then, in case a human every has to run it in the future.

Thanks! :-)
(In reply to Ed Morley [:edmorley] from comment #4)
> Oh sorry, I thought these were just for manual use; though makes sense that
> the cron job would use the same scripts. Yeah makes sense to update that one
> as well then, in case a human every has to run it in the future.
> 
> Thanks! :-)

Done :) You're welcome!
Component: Server Operations: Developer Services → General
Product: mozilla.org → Developer Services
You need to log in before you can comment on or make changes to this bug.