758201 - use PlacesUtils for LMANNO constants

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

From https://bugzilla.mozilla.org/show_bug.cgi?id=613588#c117

Just for coherence, should switch these to PlacesUtils

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Comment 2

[[e-mail]]

(In reply to Marco Bonardo from comment #0)
> Just for coherence, should switch these to PlacesUtils
coherence? It's actually a bug, since "this" is the global object in those nested functions, and those constants don't exist there, of course.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to [e-mail] from comment #2)
> coherence? It's actually a bug, since "this" is the global object in those
> nested functions, and those constants don't exist there, of course.

ugh, sorry, missed the context.  Will be better to backport the fix to Aurora.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1a4f4981595

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 626804 [details] [diff] [review]
patch v1.0

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 613588
User impact if declined: There is potential disruption in bookmarks json backups, drag&drop, copy&paste of livemark items
Testing completed (on m-c, etc.): landing on m-c
Risk to taking this patch (and alternatives if risky): just changing some "this" to the proper object, pretty safe
String or UUID changes made by this patch: none

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 626804 [details] [diff] [review]
patch v1.0

[Triage Comment]
This hasn't been a significant user pain point, as dupes/feedback haven't been piling up, so this doesn't meet our criteria for landing after the final beta.

Approving for Aurora 14, however.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/08724aa1a626

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d1a4f4981595