758231 - Session is not restored after OOM

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Andreea Pod]

Build: Firefox 14 Beta 3
Device: LG Optimus 2X (Android 2.2.2)

Steps to reproduce:
1. Open a few tabs
2. Crash the browser with OOM
3. reopen Fennec

Expected results:
- the previous session should be restored

Actual results:
- only about:home is opened and tabs that were opened are now listed in Your tabs from last time section.

Note: on the LG Optimus 2X I reproduce this using this page: http://www.race.u-tokyo.ac.jp/~uchida/blogdata/dataset1_community_large.png.

Comment 1

[Andreea Pod]

Attachment: log

Comment 2

[Adrian Tamas (:AdrianT)]

The issue is still reproducible on Firefox Mobile 15.0b2 using the HTC Desire running Android 2.2.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Andreea Pod from comment #0)
> 2. Crash the browser with OOM
How are you crashing with OOM?

qawanted to retest

Comment 4

[Andreea Pod]

(In reply to Brad Lassey [:blassey] from comment #3)
> (In reply to Andreea Pod from comment #0)
> > 2. Crash the browser with OOM
> How are you crashing with OOM?

I try to open this link: http://photos4.meetupstatic.com/photos/event/b/0/7/e/highres_117945182.jpeg (http://goo.gl/S3v22)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Two reason why we won't restore:
1. You took longer than 30 seconds to restart Fennec
2. This was the second restore attempt. We don't attempt to restore if we crash during a previous restore attempt.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Using an up to date nightly.

On my G2 opening either link reboots the phone. Which seems to be another case where the session is not auto restored. 

Using a Galaxy Nexus Android 4.0.4 opening both links OOMs Firefox and then this bug which I had open was restored.

Comment 7

[Joe Walker [:jwalker]]

I've just seen something similar to this, which I assume to be an OOM. Galaxy Tab, trying to submit a bugzilla bug, half way through, return to home screen an play store for more information, then Firefox is missing from list of recent apps, and on re-launching all context in bugzilla was lost.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Brian: Is this still an issue (as originally filed)?

Comment 9

[Brian Nicholson (:bnicholson)]

(In reply to Mark Finkle (:mfinkle) from comment #8)
> Brian: Is this still an issue (as originally filed)?

When we OOM in the foreground, it's treated as a crash since there's no bundle saved, so your rules from comment 5 apply. As for whether this is the behavior we actually want, I've raised this question at https://bugzilla.mozilla.org/show_bug.cgi?id=801412#c6.

(In reply to Joe Walker [:joe_walker] [:jwalker] from comment #7)
> I've just seen something similar to this, which I assume to be an OOM.
> Galaxy Tab, trying to submit a bugzilla bug, half way through, return to
> home screen an play store for more information, then Firefox is missing from
> list of recent apps, and on re-launching all context in bugzilla was lost.

If this is a background OOM, then we should always restore, so not doing so would be a bug. But if Firefox is missing from the recent apps list, this doesn't sound like an OOM kill; Android makes it look like OOM'ed apps are still running to make the kill/restore transparent to the user. Do you have any task killers installed? They could be responsible for this kind of behavior.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

WFM based on comment 6