758248 - fuelApplication.js Window._shutdown() removeEventListener() call is wrong

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from bug 758102 comment #2)
> {
> 97     this._tabbrowser.tabContainer.addEventListener(aType,
> 123       this._tabbrowser.removeEventListener(type, this._cleanup[type],
> true);
> }
> 
> See
> http://hg.mozilla.org/mozilla-central/rev/8ca8630b0c88
> 
> Is FF missing a '.tabContainer'?


(In reply to [e-mail] from bug 758102 comment #6)
> Sadly
> by the time the shutdown method runs, the binding no longer exists. I think
> the workaround might be to store the tabContainer in a property too, but
> :dao might have other ideas, after all he's going to have to fix the same
> bug ;-)

Comment 1

[Dão Gottwald [:dao]]

bug 750454 will fix this

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to Dão Gottwald [:dao] from comment #1)
> bug 750454 will fix this

It did in its
http://hg.mozilla.org/mozilla-central/rev/0a53a1ca7be0

V.Fixed

Comment 3

[Serge Gautherie (:sgautherie)]

Branches would still like a fix for this very bug.

Comment 4

[Justin Lebar (not reading bugmail)]

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> Branches would still like a fix for this very bug.

The fix is unfortunately kind of large.  And since this code isn't well-tested, I wanted this to ride the trains.  Perhaps there's a way to write a smaller fix.

That said, I'm really surprised we haven't seen any regressions off the FUEL bug.  I'm worried that all of a sudden people will realize that that I broke their favorite add-on.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Justin Lebar [:jlebar] from comment #4)
> Perhaps there's a way to write a smaller fix.

Per comment 0, I would expect a "one-liner" fix:
something similar to bug 758102 patch Dv1-SM211.

Comment 6

[Justin Lebar (not reading bugmail)]

> Per comment 0, I would expect a "one-liner" fix

Oh, I'm sorry; I thought this was a different bug.

If this is shutdown-only code, why does it matter?