The default bug view has changed. See this FAQ.

Remove PDF Viewer addon on update

VERIFIED FIXED in Firefox 15

Status

()

Firefox
PDF Viewer
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: JK, Assigned: yury)

Tracking

Trunk
Firefox 16
x86
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox15+ verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
In Bug 740795, PDF Viewer was changed to not be shipped as an add-on. However, the update process doesn't remove the addon from the \extensions folder.
(Reporter)

Updated

5 years ago
Blocks: 740795
(Reporter)

Comment 1

5 years ago
Reproduction:
Install an old Nightly build, which has PDF Viewer as an add-on.
Update it to latest version (in which it is no longer an add-on).

Result:
PDF Viewer is still listed as an add-on.

Expected result:
PDF Viewer should not be listed as an add-on.
We need to add it to removed-files.in, I guess?
Status: UNCONFIRMED → NEW
Ever confirmed: true
tracking-firefox15: --- → +
(Assignee)

Comment 3

5 years ago
To replicate:

1. Install Nightly from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012-05-20-03-05-30-mozilla-central/
2. Open "About Nightly" to update the browser
(Assignee)

Comment 4

5 years ago
Created attachment 630042 [details] [diff] [review]
Add uriloader@pdf.js.xpi to removed-files

Looking at the history (blame/bugs) of the removed-files.in, adding the entry in this file shall solve the issue.
Attachment #630042 - Flags: review?(khuey)
Attachment #630042 - Flags: review?(khuey) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 630145 [details] [diff] [review]
patch for checkin
Assignee: nobody → async.processingjs
Attachment #630042 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
AIUI, this is only applicable to channels that have previously shipped the add-on version, which doesn't include Aurora. So this isn't actually a concern for 15, and we don't actually need to backport the patch.
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #6)
> AIUI, this is only applicable to channels that have previously shipped the
> add-on version, which doesn't include Aurora. So this isn't actually a
> concern for 15, and we don't actually need to backport the patch.

So this patch should only affect Nightly users? Hence meaning that we could land it on 16 and be done with it? If that's the case, how necessary is it to fix this bug? When this change propagates through to the other release channels, it will just add extra code paths that aren't needed.
(In reply to Jared Wein [:jaws] from comment #7)
> (In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment
> #6)
> > AIUI, this is only applicable to channels that have previously shipped the
> > add-on version, which doesn't include Aurora. So this isn't actually a
> > concern for 15, and we don't actually need to backport the patch.
> 
> So this patch should only affect Nightly users? Hence meaning that we could
> land it on 16 and be done with it? If that's the case, how necessary is it
> to fix this bug? When this change propagates through to the other release
> channels, it will just add extra code paths that aren't needed.

It would also affect users who switched from Nightly to other channels, but really the patch is so simple it isn't worth thinking about. We should just take it and move along.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7985ee3a7734
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/7985ee3a7734
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 630145 [details] [diff] [review]
patch for checkin

[Triage Comment]
a=me
Attachment #630145 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/399d0a248065
status-firefox15: --- → fixed
(In reply to JK from comment #1)
> Reproduction:
> Install an old Nightly build, which has PDF Viewer as an add-on.
> Update it to latest version (in which it is no longer an add-on).
> 
> Result:
> PDF Viewer is still listed as an add-on.
> 
> Expected result:
> PDF Viewer should not be listed as an add-on.

So in order to test this on FF 15, I installed FF 14b12, then the PDF Viewer addon and then updated to FF 15b3.
PDF Viewer is still listed as an add-on.
Any thoughts?
(Assignee)

Comment 14

5 years ago
> So in order to test this on FF 15, I installed FF 14b12, then the PDF Viewer
> addon and then updated to FF 15b3.
> PDF Viewer is still listed as an add-on.
> Any thoughts?

Don't install PDF Viewer addon -- it shall be a part of the FF (also see comment 3)
So:
1. Installed Nightly 2012-05-20 (comment 3) --> PDF Viewer listed as an add-on
2. Pave over installation of FF 15b3 (comment 8) --> PDF Viewer not in add-ons list

Verified fixed on FF 15b3 on Win 7.
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
You need to log in before you can comment on or make changes to this bug.