Let MFBT LinkedList allow const

RESOLVED FIXED in mozilla15

Status

()

Core
MFBT
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 626977 [details] [diff] [review]
constipate LinkedList

LinkedList doesn't currently have const-qualified methods, so one can't perform even read-only operations on const LinkedList references.
Attachment #626977 - Flags: review?(justin.lebar+bug)
Attachment #626977 - Flags: feedback?(jwalden+bmo)
(Assignee)

Updated

5 years ago
Blocks: 758404
Comment on attachment 626977 [details] [diff] [review]
constipate LinkedList

r=me, but we should wait for Waldo to at least sign off on my reviewing this stuff.

My preference would be not to repeat the comments for these methods, but whatever you and Waldo want to do is fine.
Attachment #626977 - Flags: review?(justin.lebar+bug) → review+
Comment on attachment 626977 [details] [diff] [review]
constipate LinkedList

Review of attachment 626977 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I'd say just mash the const methods up against the non-const methods and let the lack of spacing imply identical interfaces, or something like that.
Attachment #626977 - Flags: feedback?(jwalden+bmo) → feedback+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/b687f70200f7

Applied the idea from comment 2.
Assignee: nobody → bjacob
Target Milestone: --- → mozilla15

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b687f70200f7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.