Closed
Bug 758396
Opened 13 years ago
Closed 13 years ago
Let MFBT LinkedList allow const
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bjacob, Assigned: bjacob)
References
Details
Attachments
(1 file)
|
5.98 KB,
patch
|
justin.lebar+bug
:
review+
Waldo
:
feedback+
|
Details | Diff | Splinter Review |
LinkedList doesn't currently have const-qualified methods, so one can't perform even read-only operations on const LinkedList references.
Attachment #626977 -
Flags: review?(justin.lebar+bug)
Attachment #626977 -
Flags: feedback?(jwalden+bmo)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 626977 [details] [diff] [review]
constipate LinkedList
r=me, but we should wait for Waldo to at least sign off on my reviewing this stuff.
My preference would be not to repeat the comments for these methods, but whatever you and Waldo want to do is fine.
Attachment #626977 -
Flags: review?(justin.lebar+bug) → review+
|
||
Comment 2•13 years ago
|
||
Comment on attachment 626977 [details] [diff] [review]
constipate LinkedList
Review of attachment 626977 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, I'd say just mash the const methods up against the non-const methods and let the lack of spacing imply identical interfaces, or something like that.
Attachment #626977 -
Flags: feedback?(jwalden+bmo) → feedback+
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/b687f70200f7
Applied the idea from comment 2.
Assignee: nobody → bjacob
Target Milestone: --- → mozilla15
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•