758413 - Move of jpeg to gkmedia breaks anything using JPEG_LIBS (which now refers to a library we don't build)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Bug 750867 changed the library name of jpeg for windows, but missed one use of the old name in configure.in.

The old name was jpeg3250.lib, the new one is mozjpeg.lib (on non-windows I think it's always mozjpeg.lib)

See in configure.in (for mingw only):

   MOZ_JPEG_LIBS='$(call EXPAND_LIBNAME_PATH,jpeg32$(VERSION_NUMBER),$(DEPTH)/media/libjpeg)'

This should be removed I think and just leave the default mozjpeg value.  (Running check build now)

This showed up because webrtc used JPEG_LIBS in a makefile, and it had the old name.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

The same goes for MOZ_PNG_LIBS I think.

Comment 2

[Mike Hommey [:glandium]]

(In reply to Randell Jesup [:jesup] from comment #0)
> This showed up because webrtc used JPEG_LIBS in a makefile, and it had the
> old name.

And that works ? Because if you include jpeg libs twice (once in webrtc and then once in gkmedia), that should break.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

It appears to work, but I'll be removing webrtc's JPEG_LIBS mod from gkmedia (it was added to the gkmedia link because webrtc uses jpeg, but at the time jpeg was in xul, so we had to live with a second copy, at least temporarily).  It was on the list to find a way to avoid duplicate copies, but with jpeg in gkmedia that's no longer an issue.  We've spent a LOT of time dealing with fallout of the gkmedia split...

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b50468e9c210

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b50468e9c210