Move of jpeg to gkmedia breaks anything using JPEG_LIBS (which now refers to a library we don't build)

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jesup, Assigned: Ehsan)

Tracking

Other Branch
mozilla16
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Bug 750867 changed the library name of jpeg for windows, but missed one use of the old name in configure.in.

The old name was jpeg3250.lib, the new one is mozjpeg.lib (on non-windows I think it's always mozjpeg.lib)

See in configure.in (for mingw only):

   MOZ_JPEG_LIBS='$(call EXPAND_LIBNAME_PATH,jpeg32$(VERSION_NUMBER),$(DEPTH)/media/libjpeg)'

This should be removed I think and just leave the default mozjpeg value.  (Running check build now)

This showed up because webrtc used JPEG_LIBS in a makefile, and it had the old name.
Created attachment 626992 [details] [diff] [review]
Patch (v1)

The same goes for MOZ_PNG_LIBS I think.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #626992 - Flags: review?(ted.mielczarek)
(In reply to Randell Jesup [:jesup] from comment #0)
> This showed up because webrtc used JPEG_LIBS in a makefile, and it had the
> old name.

And that works ? Because if you include jpeg libs twice (once in webrtc and then once in gkmedia), that should break.
(Reporter)

Comment 3

5 years ago
It appears to work, but I'll be removing webrtc's JPEG_LIBS mod from gkmedia (it was added to the gkmedia link because webrtc uses jpeg, but at the time jpeg was in xul, so we had to live with a second copy, at least temporarily).  It was on the list to find a way to avoid duplicate copies, but with jpeg in gkmedia that's no longer an issue.  We've spent a LOT of time dealing with fallout of the gkmedia split...
Attachment #626992 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b50468e9c210
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/b50468e9c210
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.