Closed
Bug 758448
Opened 13 years ago
Closed 13 years ago
Make callback optional for runEmulatorCmd
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: philikon, Assigned: philikon)
Details
Attachments
(1 file)
|
2.50 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
When we use the emulator to mutate state, we often do that to trigger a Gecko event. In that case we care more about the Gecko event triggering than the emulator return value. Marionette checks that alreayd anyway. In those cases, we should be allowed to pass no callback.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → philipp
Attachment #627032 -
Flags: review?(jgriffin)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 627032 [details] [diff] [review]
v1
Review of attachment 627032 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm!
Attachment #627032 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla15
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•