Closed Bug 758448 Opened 10 years ago Closed 10 years ago

Make callback optional for runEmulatorCmd

Categories

(Testing :: Marionette, defect)

Product:
Testing
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: philikon, Assigned: philikon)

Details

Attachments

(1 file)

v1
2.50 KB, patch
jgriffin
: review+
Details | Diff | Splinter Review 
When we use the emulator to mutate state, we often do that to trigger a Gecko event. In that case we care more about the Gecko event triggering than the emulator return value. Marionette checks that alreayd anyway. In those cases, we should be allowed to pass no callback.
Attached patch v1 — — Splinter Review
Assignee: nobody → philipp
Attachment #627032 - Flags: review?(jgriffin)
Comment on attachment 627032 [details] [diff] [review]
v1

Review of attachment 627032 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #627032 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/190eab3e5ef0
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.