758457 - Device WebAPI Marionette tests for Contacts API

Status: RESOLVED DUPLICATE of bug 816893

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Philipp von Weitershausen [:philikon]]

Most of the contact API is not specific to Gonk and the device environment, so I suggest writing traditional DOM API tests (mochitests) here. We should find a way to run tests for APIs like these (settings, contacts, etc.) as well as unit tests for other parts (e.g. the RIL has a few xpcshell tests) on the CI.

Comment 2

[Jonathan Griffin (:jgriffin)]

I hope to have mochitest-plain running on the CI by next week.  xpcshell tests will be a little further off.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Philipp von Weitershausen [:philikon] from comment #1)
> Most of the contact API is not specific to Gonk and the device environment

You meant the Gecko-native implementation, right?

> so I suggest writing traditional DOM API tests (mochitests) here.

Agreed.

> We should find a way to run tests for APIs like these (settings,

Settings is highly system-dependent, would recommend using "device tests" for these.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> (In reply to Philipp von Weitershausen [:philikon] from comment #1)
> > Most of the contact API is not specific to Gonk and the device environment
> 
> You meant the Gecko-native implementation, right?

Yes, right. Confusing terminology, sry.

> > We should find a way to run tests for APIs like these (settings,
> 
> Settings is highly system-dependent, would recommend using "device tests"
> for these.

Well. There's two different layers there. One is the actual functionality of the API. Requests, Locks, storage, etc. This can be done with dummy data in mochitests, much like Contacts API tests. The other layer is the fact that a bunch of Gecko services react when certain settings change. That will indeed have to be tested in "device tests", but I consider them more part of whatever component those settings affect than the settings API tests.

Comment 5

[Gregor Wagner [:gwagner]]

I already have plenty mochitests in dom/contacts/tests. But we need something for testing contacts import from sim card.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Marionette tests for importing SIM contact is done in Bug 816893