The default bug view has changed. See this FAQ.

When seeking in an unbuffered range after having ended a media, networkState is NETWORK_IDLE

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

unspecified
mozilla15
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
STR :
1. Load a page containing a video ;
2. Start playing the video, the networkState is NETWORK_LOADING ;
3. Seek near the end of the video, the video will buffer from that point, and then the download finishes. The networkState is now NETWORK_IDLE ;
4. Seek in an unbuffered range, in the middle of the video.

Expected result :

Per spec [1], the networkState should be NETWORK_LOADING :

> NETWORK_LOADING (numeric value 2)
>     The user agent is actively trying to download data.

Actual result :

networkState is NETWORK_IDLE.

I could reproduce this on current release, today's nightly. Not sure if it is a regression or it has always been like that.
(Assignee)

Updated

5 years ago
Blocks: 559468
(Assignee)

Updated

5 years ago
Assignee: nobody → paul
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 628233 [details] [diff] [review]
Patch v0 : When opening a channel, set the networkState to NETWORK_LOADING.

I'm currently also (re)writing test_networkState.html to be sure not to regress here (considering the incoming stop download / resume download feature), but I need other change to land before I can write a reliable test.
Attachment #628233 - Flags: review?(chris.double)
(Assignee)

Updated

5 years ago
Depends on: 759659

Comment 2

5 years ago
Comment on attachment 628233 [details] [diff] [review]
Patch v0 : When opening a channel, set the networkState to NETWORK_LOADING.

Review of attachment 628233 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/public/nsHTMLMediaElement.h
@@ +155,5 @@
>    // asked the decoder to resumed the download.
> +  // If aForce is True, ignore the fact that the download has previously
> +  // finished. We are downloading the middle of the media after having
> +  // downloaded the end, we need to notify the element a download in ongoing.
> +  void DownloadResumed(bool aForce = false);

Can we call this 'aForceNetworkLoading' or something like that? 'aForce' doesn't really explain what it does.
Attachment #628233 - Flags: review?(chris.double) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 628560 [details] [diff] [review]
Addressed Chris' comments.
Attachment #628233 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/28fe5eec1ca3
Keywords: checkin-needed
Target Milestone: --- → mozilla14

Comment 5

5 years ago
My apologies Paul, I had to fix a merge conflict and when committing and I forgot to set the author information for the patch to refer to you.

Updated

5 years ago
Target Milestone: mozilla14 → mozilla15
https://hg.mozilla.org/mozilla-central/rev/28fe5eec1ca3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.