Last Comment Bug 758483 - "struct utsname" should be used to declare unameobj
: "struct utsname" should be used to declare unameobj
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: x86 Solaris
: -- normal (vote)
: mozilla15
Assigned To: Ginn Chen
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-24 19:04 PDT by Ginn Chen
Modified: 2012-05-28 10:12 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (702 bytes, patch)
2012-05-24 19:05 PDT, Ginn Chen
jacob.benoit.1: review+
Details | Diff | Review

Description Ginn Chen 2012-05-24 19:04:09 PDT
On Solaris <sys/utsname.h>, it has
extern struct utsname utsname;

so it's necessary to use "struct utsname unameobj" instead of "utsname unameobj" for disambiguation.
Comment 1 Ginn Chen 2012-05-24 19:05:30 PDT
Created attachment 627069 [details] [diff] [review]
patch
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2012-05-24 19:15:32 PDT
Comment on attachment 627069 [details] [diff] [review]
patch

Review of attachment 627069 [details] [diff] [review]:
-----------------------------------------------------------------

*sigh*
Comment 4 Ed Morley [:emorley] 2012-05-28 10:12:19 PDT
https://hg.mozilla.org/mozilla-central/rev/fe69d3aa1cc5

Note You need to log in before you can comment on or make changes to this bug.