correct comment syntax for mapfile

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

unspecified
mozilla15
x86
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
the mapfile use # for comments, not /* */
(Assignee)

Comment 1

5 years ago
Created attachment 627070 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627070 - Flags: review?

Comment 2

5 years ago
Adding Gerv so the script can be adjusted accordingly.
Blocks: 715549
Attachment #627070 - Flags: review? → review+
Thank you. But intl/uconv/ucvja/japanese.map uses /* */ and //. Is this just an unfortunate clash of filetypes under the same extension?

There are only four .map files in m-c:
./js/src/config/solaris_ia32.map
./intl/uconv/ucvja/japanese.map
./config/solaris_ia32.map
./security/nss/tests/libpkix/cert_trust.map

Gerv
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a09580f17723

Only solaris_ia32.map are ld map files.

Comment 5

5 years ago
Please can you set the milestone when landing on inbound. Thanks :-)

https://hg.mozilla.org/mozilla-central/rev/a09580f17723
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.