Last Comment Bug 758484 - correct comment syntax for mapfile
: correct comment syntax for mapfile
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86 Solaris
: -- normal (vote)
: mozilla15
Assigned To: Ginn Chen
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: mpl2
  Show dependency treegraph
 
Reported: 2012-05-24 19:10 PDT by Ginn Chen
Modified: 2012-05-28 10:12 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.14 KB, patch)
2012-05-24 19:11 PDT, Ginn Chen
ted: review+
Details | Diff | Splinter Review

Description Ginn Chen 2012-05-24 19:10:31 PDT
the mapfile use # for comments, not /* */
Comment 1 Ginn Chen 2012-05-24 19:11:27 PDT
Created attachment 627070 [details] [diff] [review]
patch
Comment 2 Ed Morley [:emorley] 2012-05-24 19:35:50 PDT
Adding Gerv so the script can be adjusted accordingly.
Comment 3 Gervase Markham [:gerv] 2012-05-25 07:10:34 PDT
Thank you. But intl/uconv/ucvja/japanese.map uses /* */ and //. Is this just an unfortunate clash of filetypes under the same extension?

There are only four .map files in m-c:
./js/src/config/solaris_ia32.map
./intl/uconv/ucvja/japanese.map
./config/solaris_ia32.map
./security/nss/tests/libpkix/cert_trust.map

Gerv
Comment 4 Ginn Chen 2012-05-27 18:39:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a09580f17723

Only solaris_ia32.map are ld map files.
Comment 5 Ed Morley [:emorley] 2012-05-28 10:12:00 PDT
Please can you set the milestone when landing on inbound. Thanks :-)

https://hg.mozilla.org/mozilla-central/rev/a09580f17723

Note You need to log in before you can comment on or make changes to this bug.