Closed Bug 758484 Opened 14 years ago Closed 14 years ago

correct comment syntax for mapfile

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Solaris
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

Attachments

(1 file)

patch
1.14 KB, patch
ted
: review+
Details | Diff | Splinter Review
the mapfile use # for comments, not /* */
Attached patch patch — — Splinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627070 - Flags: review?
Adding Gerv so the script can be adjusted accordingly.
Blocks: mpl2
Attachment #627070 - Flags: review? → review+
Thank you. But intl/uconv/ucvja/japanese.map uses /* */ and //. Is this just an unfortunate clash of filetypes under the same extension? There are only four .map files in m-c: ./js/src/config/solaris_ia32.map ./intl/uconv/ucvja/japanese.map ./config/solaris_ia32.map ./security/nss/tests/libpkix/cert_trust.map Gerv
https://hg.mozilla.org/integration/mozilla-inbound/rev/a09580f17723 Only solaris_ia32.map are ld map files.
Please can you set the milestone when landing on inbound. Thanks :-) https://hg.mozilla.org/mozilla-central/rev/a09580f17723
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: