Last Comment Bug 758487 - libopus fails to compile on Solaris/SPARC
: libopus fails to compile on Solaris/SPARC
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: unspecified
: Sun Solaris
: -- normal (vote)
: mozilla15
Assigned To: Ginn Chen
: Maire Reavy [:mreavy]
Depends on:
  Show dependency treegraph
Reported: 2012-05-24 19:22 PDT by Ginn Chen
Modified: 2012-05-28 10:11 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (539 bytes, patch)
2012-05-24 19:23 PDT, Ginn Chen
giles: review+
Details | Diff | Splinter Review

Description Ginn Chen 2012-05-24 19:22:02 PDT
alloca.h is required to use alloca
Comment 1 Ginn Chen 2012-05-24 19:23:05 PDT
Created attachment 627071 [details] [diff] [review]
Comment 2 Ralph Giles (:rillian) needinfo me 2012-05-25 10:58:37 PDT
Comment on attachment 627071 [details] [diff] [review]

Looks good. Can you update the patch with your name and a commit message, please? Saves a step for the committer. Something like:

From: <your email>
Bug 627071 - Fix libopus compile on Solaris/SPARC - r=rillian

alloca.h is required to use alloca.h.

diff ....

You may find the 'git hgp' alias at helpful, although just a 'git show' or 'format-patch' often works fine with mercurial.
Comment 4 Ralph Giles (:rillian) needinfo me 2012-05-28 09:57:56 PDT
Thanks. Sorry, didn't realize you would push the patch yourself.
Comment 5 Ed Morley [:emorley] 2012-05-28 10:11:39 PDT
Please can you set the milestone when landing on inbound. Thanks :-)

Note You need to log in before you can comment on or make changes to this bug.