libopus fails to compile on Solaris/SPARC

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

unspecified
mozilla15
Sun
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
alloca.h is required to use alloca
(Assignee)

Comment 1

5 years ago
Created attachment 627071 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627071 - Flags: review?(giles)
Comment on attachment 627071 [details] [diff] [review]
patch

Looks good. Can you update the patch with your name and a commit message, please? Saves a step for the committer. Something like:

From: <your email>
Bug 627071 - Fix libopus compile on Solaris/SPARC - r=rillian

alloca.h is required to use alloca.h.

diff ....


You may find the 'git hgp' alias at http://www.bluishcoder.co.nz/2011/04/16/my-git-workflow-for-mozilla-development.html helpful, although just a 'git show' or 'format-patch' often works fine with mercurial.
Attachment #627071 - Flags: review?(giles) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/606af29f167c
Thanks. Sorry, didn't realize you would push the patch yourself.
Please can you set the milestone when landing on inbound. Thanks :-)

https://hg.mozilla.org/mozilla-central/rev/606af29f167c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.