Closed
Bug 758487
Opened 14 years ago
Closed 14 years ago
libopus fails to compile on Solaris/SPARC
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
|
539 bytes,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
alloca.h is required to use alloca
|
||
Comment 2•14 years ago
|
||
Comment on attachment 627071 [details] [diff] [review]
patch
Looks good. Can you update the patch with your name and a commit message, please? Saves a step for the committer. Something like:
From: <your email>
Bug 627071 - Fix libopus compile on Solaris/SPARC - r=rillian
alloca.h is required to use alloca.h.
diff ....
You may find the 'git hgp' alias at http://www.bluishcoder.co.nz/2011/04/16/my-git-workflow-for-mozilla-development.html helpful, although just a 'git show' or 'format-patch' often works fine with mercurial.
Attachment #627071 -
Flags: review?(giles) → review+
|
|
||
Comment 4•14 years ago
|
||
Thanks. Sorry, didn't realize you would push the patch yourself.
|
||
Comment 5•14 years ago
|
||
Please can you set the milestone when landing on inbound. Thanks :-)
https://hg.mozilla.org/mozilla-central/rev/606af29f167c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•