Last Comment Bug 758494 - Make double conversion built with Solaris Studio compiler
: Make double conversion built with Solaris Studio compiler
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MFBT (show other bugs)
: unspecified
: All Solaris
: -- normal (vote)
: mozilla15
Assigned To: Ginn Chen
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-24 20:33 PDT by Ginn Chen
Modified: 2012-06-02 11:50 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.23 KB, patch)
2012-05-24 20:34 PDT, Ginn Chen
no flags Details | Diff | Splinter Review
patch v2 (2.99 KB, patch)
2012-05-24 21:51 PDT, Ginn Chen
jwalden+bmo: review+
Details | Diff | Splinter Review

Description Ginn Chen 2012-05-24 20:33:05 PDT
With Solaris Studio, __sparc is defined instead of __sparc__, __i386 is defined instead of __i386__
Comment 1 Ginn Chen 2012-05-24 20:34:07 PDT
Created attachment 627085 [details] [diff] [review]
patch
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2012-05-24 20:39:35 PDT
Comment on attachment 627085 [details] [diff] [review]
patch

You need to include a patch for this in update.sh.  Also, you should upstream these changes, too, to the Google Code double-conversion project.
Comment 3 Ginn Chen 2012-05-24 21:51:04 PDT
Created attachment 627101 [details] [diff] [review]
patch v2

merged into more-architectures.patch

I also commented in http://code.google.com/p/double-conversion/issues/detail?id=28

I think it will upstream there.

Note You need to log in before you can comment on or make changes to this bug.