Make double conversion built with Solaris Studio compiler

RESOLVED FIXED in mozilla15

Status

()

Core
MFBT
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

unspecified
mozilla15
All
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.99 KB, patch
Waldo
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
With Solaris Studio, __sparc is defined instead of __sparc__, __i386 is defined instead of __i386__
(Assignee)

Comment 1

5 years ago
Created attachment 627085 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627085 - Flags: review?(mh+mozilla)
Comment on attachment 627085 [details] [diff] [review]
patch

You need to include a patch for this in update.sh.  Also, you should upstream these changes, too, to the Google Code double-conversion project.
Attachment #627085 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

5 years ago
Created attachment 627101 [details] [diff] [review]
patch v2

merged into more-architectures.patch

I also commented in http://code.google.com/p/double-conversion/issues/detail?id=28

I think it will upstream there.
Attachment #627085 - Attachment is obsolete: true
Attachment #627101 - Flags: review?(jwalden+bmo)
Attachment #627101 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7c54fa24d8
https://hg.mozilla.org/mozilla-central/rev/8d7c54fa24d8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.