Closed Bug 758494 Opened 12 years ago Closed 12 years ago

Make double conversion built with Solaris Studio compiler

Categories

(Core :: MFBT, defect)

All
Solaris
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(1 file, 1 obsolete file)

With Solaris Studio, __sparc is defined instead of __sparc__, __i386 is defined instead of __i386__
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627085 - Flags: review?(mh+mozilla)
Comment on attachment 627085 [details] [diff] [review]
patch

You need to include a patch for this in update.sh.  Also, you should upstream these changes, too, to the Google Code double-conversion project.
Attachment #627085 - Flags: review?(mh+mozilla)
Attached patch patch v2Splinter Review
merged into more-architectures.patch

I also commented in http://code.google.com/p/double-conversion/issues/detail?id=28

I think it will upstream there.
Attachment #627085 - Attachment is obsolete: true
Attachment #627101 - Flags: review?(jwalden+bmo)
Attachment #627101 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/8d7c54fa24d8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: