758561 - "ASSERTION: Mask layer has invalid transform"

Status: RESOLVED FIXED

Description

[Jesse Ruderman]

Created attachment 627156 [details]
testcase

###!!! ASSERTION: Mask layer has invalid transform.: 'maskIs2D && maskTransform.HasOnlyIntegerTranslation()', file Layers.h, line 704

###!!! ASSERTION: Mask layer has invalid transform.: 'maskTranslation.HasOnlyIntegerTranslation()', file gfx/layers/Layers.cpp, line 380

The first assertion is part of code added in:

changeset:   f3443acc097c
user:        Nicholas Cameron
summary:     Bug 716439; mask layer - member, getter, setter, dumping. r=roc

The second assertion is part of code added in:

changeset:   f7b8deeb0cc4
user:        Nicholas Cameron
summary:     Bug 716439; creating mask layers. r=roc

Comment 1

[Jesse Ruderman]

Created attachment 627157 [details]
stack trace

Comment 2

[Nick Cameron [:nrc]]

Created attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers

Review of attachment 627603 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +2796,5 @@
>    // don't build an unnecessary mask
>    if (aClip.mRoundedClipRects.IsEmpty() ||
> +      aRoundedRectClipCount <= 0 ||
> +      boundingRect.height == 0 ||
> +      boundingRect.width == 0) {

boundingRect.IsEmpty()

Comment 4

[Nick Cameron [:nrc]]

Created attachment 627608 [details] [diff] [review]
updated fix

updated according to comment - carrying r=roc

Comment 5

[Nick Cameron [:nrc]]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=8a271f4e3f32

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5

Should this have a test?

Comment 7

[Nick Cameron [:nrc]]

(In reply to Ryan VanderMeulen from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5
> 
> Should this have a test?

Yes, it probably should, I'll make one tomorrow.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9cc3b4fc60c5

Comment 9

[Nick Cameron [:nrc]]

Created attachment 628200 [details] [diff] [review]
test

Comment 10

[Nick Cameron [:nrc]]

Re-opened to add test

Comment 11

[Nick Cameron [:nrc]]

Checkin-needed for test (https://bugzilla.mozilla.org/attachment.cgi?id=628200) only, please.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11c39e974c4d

Sorry for the delay...

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11c39e974c4d