Closed Bug 758561 Opened 8 years ago Closed 8 years ago

"ASSERTION: Mask layer has invalid transform"

Categories

(Core :: Graphics: Layers, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: jruderman, Assigned: nrc)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase)

Attachments

(4 files, 1 obsolete file)

Attached file testcase
###!!! ASSERTION: Mask layer has invalid transform.: 'maskIs2D && maskTransform.HasOnlyIntegerTranslation()', file Layers.h, line 704

###!!! ASSERTION: Mask layer has invalid transform.: 'maskTranslation.HasOnlyIntegerTranslation()', file gfx/layers/Layers.cpp, line 380

The first assertion is part of code added in:

changeset:   f3443acc097c
user:        Nicholas Cameron
summary:     Bug 716439; mask layer - member, getter, setter, dumping. r=roc

The second assertion is part of code added in:

changeset:   f7b8deeb0cc4
user:        Nicholas Cameron
summary:     Bug 716439; creating mask layers. r=roc
Attached file stack trace
Attachment #627603 - Flags: review?(roc)
Comment on attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers

Review of attachment 627603 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +2796,5 @@
>    // don't build an unnecessary mask
>    if (aClip.mRoundedClipRects.IsEmpty() ||
> +      aRoundedRectClipCount <= 0 ||
> +      boundingRect.height == 0 ||
> +      boundingRect.width == 0) {

boundingRect.IsEmpty()
Attachment #627603 - Flags: review?(roc) → review+
Attached patch updated fixSplinter Review
updated according to comment - carrying r=roc
Attachment #627603 - Attachment is obsolete: true
Attachment #627608 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5

Should this have a test?
Flags: in-testsuite?
Keywords: checkin-needed
Target Milestone: --- → mozilla15
(In reply to Ryan VanderMeulen from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5
> 
> Should this have a test?

Yes, it probably should, I'll make one tomorrow.
https://hg.mozilla.org/mozilla-central/rev/9cc3b4fc60c5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attached patch testSplinter Review
Attachment #628200 - Flags: review?(roc)
Re-opened to add test
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Checkin-needed for test (https://bugzilla.mozilla.org/attachment.cgi?id=628200) only, please.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c39e974c4d

Sorry for the delay...
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/11c39e974c4d
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.