Last Comment Bug 758561 - "ASSERTION: Mask layer has invalid transform"
: "ASSERTION: Mask layer has invalid transform"
Status: RESOLVED FIXED
: assertion, regression, testcase
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Nick Cameron [:nrc]
:
:
Mentors:
Depends on:
Blocks: randomstyles
  Show dependency tree / graph
 
Reported: 2012-05-25 03:28 PDT by Jesse Ruderman
Modified: 2012-06-09 19:42 PDT (History)
3 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
testcase (159 bytes, text/html)
2012-05-25 03:28 PDT, Jesse Ruderman 		no flags Details
stack trace (16.71 KB, text/plain)
2012-05-25 03:28 PDT, Jesse Ruderman 		no flags Details
fix - don't build masks for empty layers (1.59 KB, patch)
2012-05-27 17:46 PDT, Nick Cameron [:nrc] 		roc: review+
Details | Diff | Splinter Review
updated fix (1.56 KB, patch)
2012-05-27 18:35 PDT, Nick Cameron [:nrc] 		ncameron: review+
Details | Diff | Splinter Review
test (1.26 KB, patch)
2012-05-29 20:35 PDT, Nick Cameron [:nrc] 		roc: review+
Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Jesse Ruderman 2012-05-25 03:28:17 PDT 
Created attachment 627156 [details]
testcase

###!!! ASSERTION: Mask layer has invalid transform.: 'maskIs2D && maskTransform.HasOnlyIntegerTranslation()', file Layers.h, line 704

###!!! ASSERTION: Mask layer has invalid transform.: 'maskTranslation.HasOnlyIntegerTranslation()', file gfx/layers/Layers.cpp, line 380

The first assertion is part of code added in:

changeset:   f3443acc097c
user:        Nicholas Cameron
summary:     Bug 716439; mask layer - member, getter, setter, dumping. r=roc

The second assertion is part of code added in:

changeset:   f7b8deeb0cc4
user:        Nicholas Cameron
summary:     Bug 716439; creating mask layers. r=roc
Comment 1 Jesse Ruderman 2012-05-25 03:28:42 PDT 
Created attachment 627157 [details]
stack trace
Comment 2 Nick Cameron [:nrc] 2012-05-27 17:46:23 PDT 
Created attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers
Comment 3 Robert O'Callahan (:roc) (email my personal email if necessary) 2012-05-27 17:52:52 PDT 
Comment on attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers

Review of attachment 627603 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +2796,5 @@
>    // don't build an unnecessary mask
>    if (aClip.mRoundedClipRects.IsEmpty() ||
> +      aRoundedRectClipCount <= 0 ||
> +      boundingRect.height == 0 ||
> +      boundingRect.width == 0) {

boundingRect.IsEmpty()
Comment 4 Nick Cameron [:nrc] 2012-05-27 18:35:00 PDT 
Created attachment 627608 [details] [diff] [review]
updated fix

updated according to comment - carrying r=roc
Comment 5 Nick Cameron [:nrc] 2012-05-27 23:58:41 PDT 
Try push: https://tbpl.mozilla.org/?tree=Try&rev=8a271f4e3f32
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-05-28 18:11:23 PDT 
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5

Should this have a test?
Comment 7 Nick Cameron [:nrc] 2012-05-28 23:56:37 PDT 
(In reply to Ryan VanderMeulen from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5
> 
> Should this have a test?

Yes, it probably should, I'll make one tomorrow.
Comment 8 Ed Morley [:emorley] 2012-05-29 10:19:55 PDT 
https://hg.mozilla.org/mozilla-central/rev/9cc3b4fc60c5
Comment 9 Nick Cameron [:nrc] 2012-05-29 20:35:52 PDT 
Created attachment 628200 [details] [diff] [review]
test
Comment 10 Nick Cameron [:nrc] 2012-05-29 20:36:23 PDT 
Re-opened to add test
Comment 11 Nick Cameron [:nrc] 2012-05-29 20:44:13 PDT 
Checkin-needed for test (https://bugzilla.mozilla.org/attachment.cgi?id=628200) only, please.
Comment 12 Ryan VanderMeulen [:RyanVM] 2012-06-09 11:24:19 PDT 
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c39e974c4d

Sorry for the delay...
Comment 13 Ryan VanderMeulen [:RyanVM] 2012-06-09 19:42:29 PDT 
https://hg.mozilla.org/mozilla-central/rev/11c39e974c4d
Note You need to log in before you can comment on or make changes to this bug.