"ASSERTION: Mask layer has invalid transform"

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: nrc)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla15
x86_64
Mac OS X
assertion, regression, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 627156 [details]
testcase

###!!! ASSERTION: Mask layer has invalid transform.: 'maskIs2D && maskTransform.HasOnlyIntegerTranslation()', file Layers.h, line 704

###!!! ASSERTION: Mask layer has invalid transform.: 'maskTranslation.HasOnlyIntegerTranslation()', file gfx/layers/Layers.cpp, line 380

The first assertion is part of code added in:

changeset:   f3443acc097c
user:        Nicholas Cameron
summary:     Bug 716439; mask layer - member, getter, setter, dumping. r=roc

The second assertion is part of code added in:

changeset:   f7b8deeb0cc4
user:        Nicholas Cameron
summary:     Bug 716439; creating mask layers. r=roc
(Reporter)

Comment 1

5 years ago
Created attachment 627157 [details]
stack trace
Assignee: nobody → ncameron
(Assignee)

Comment 2

5 years ago
Created attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers
Attachment #627603 - Flags: review?(roc)
Comment on attachment 627603 [details] [diff] [review]
fix - don't build masks for empty layers

Review of attachment 627603 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +2796,5 @@
>    // don't build an unnecessary mask
>    if (aClip.mRoundedClipRects.IsEmpty() ||
> +      aRoundedRectClipCount <= 0 ||
> +      boundingRect.height == 0 ||
> +      boundingRect.width == 0) {

boundingRect.IsEmpty()
Attachment #627603 - Flags: review?(roc) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 627608 [details] [diff] [review]
updated fix

updated according to comment - carrying r=roc
Attachment #627603 - Attachment is obsolete: true
Attachment #627608 - Flags: review+
(Assignee)

Comment 5

5 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=8a271f4e3f32
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5

Should this have a test?
Flags: in-testsuite?
Keywords: checkin-needed
Target Milestone: --- → mozilla15
(Assignee)

Comment 7

5 years ago
(In reply to Ryan VanderMeulen from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5
> 
> Should this have a test?

Yes, it probably should, I'll make one tomorrow.
https://hg.mozilla.org/mozilla-central/rev/9cc3b4fc60c5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

5 years ago
Created attachment 628200 [details] [diff] [review]
test
Attachment #628200 - Flags: review?(roc)
(Assignee)

Comment 10

5 years ago
Re-opened to add test
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #628200 - Flags: review?(roc) → review+
(Assignee)

Comment 11

5 years ago
Checkin-needed for test (https://bugzilla.mozilla.org/attachment.cgi?id=628200) only, please.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c39e974c4d

Sorry for the delay...
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/11c39e974c4d
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.