Status
()
People
(Reporter: jruderman, Assigned: nrc)
Tracking
(Blocks: 1 bug, {assertion, regression, testcase})
Trunk
mozilla15
x86_64
macOS
assertion, regression, testcase
Points:
---
Bug Flags:
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(4 attachments, 1 obsolete attachment)
|
159 bytes,
text/html
|
Details | |
|
16.71 KB,
text/plain
|
Details | |
|
1.56 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
|
1.26 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Created attachment 627156 [details] testcase ###!!! ASSERTION: Mask layer has invalid transform.: 'maskIs2D && maskTransform.HasOnlyIntegerTranslation()', file Layers.h, line 704 ###!!! ASSERTION: Mask layer has invalid transform.: 'maskTranslation.HasOnlyIntegerTranslation()', file gfx/layers/Layers.cpp, line 380 The first assertion is part of code added in: changeset: f3443acc097c user: Nicholas Cameron summary: Bug 716439; mask layer - member, getter, setter, dumping. r=roc The second assertion is part of code added in: changeset: f7b8deeb0cc4 user: Nicholas Cameron summary: Bug 716439; creating mask layers. r=roc
|
(Reporter) | |
Comment 1•7 years ago
|
||
Created attachment 627157 [details]
stack trace
Assignee: nobody → ncameron
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 627603 [details] [diff] [review] fix - don't build masks for empty layers
Attachment #627603 -
Flags: review?(roc)
Comment on attachment 627603 [details] [diff] [review] fix - don't build masks for empty layers Review of attachment 627603 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/base/FrameLayerBuilder.cpp @@ +2796,5 @@ > // don't build an unnecessary mask > if (aClip.mRoundedClipRects.IsEmpty() || > + aRoundedRectClipCount <= 0 || > + boundingRect.height == 0 || > + boundingRect.width == 0) { boundingRect.IsEmpty()
Attachment #627603 -
Flags: review?(roc) → review+
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Created attachment 627608 [details] [diff] [review] updated fix updated according to comment - carrying r=roc
Attachment #627603 -
Attachment is obsolete: true
Attachment #627608 -
Flags: review+
|
|
(Assignee) | |
Comment 5•7 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=8a271f4e3f32
|
|
(Assignee) | |
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5 Should this have a test?
Flags: in-testsuite?
Keywords: checkin-needed
Target Milestone: --- → mozilla15
|
|
(Assignee) | |
Comment 7•7 years ago
|
||
(In reply to Ryan VanderMeulen from comment #6) > https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc3b4fc60c5 > > Should this have a test? Yes, it probably should, I'll make one tomorrow.
|
||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9cc3b4fc60c5
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
|
|
(Assignee) | |
Comment 9•7 years ago
|
||
Created attachment 628200 [details] [diff] [review] test
Attachment #628200 -
Flags: review?(roc)
|
|
(Assignee) | |
Comment 10•7 years ago
|
||
Re-opened to add test
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #628200 -
Flags: review?(roc) → review+
|
|
(Assignee) | |
Comment 11•7 years ago
|
||
Checkin-needed for test (https://bugzilla.mozilla.org/attachment.cgi?id=628200) only, please.
Keywords: checkin-needed
|
|
||
Comment 12•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c39e974c4d Sorry for the delay...
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 13•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/11c39e974c4d
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•