Closed Bug 758564 Opened 12 years ago Closed 12 years ago

Port |Bug 562431 - Rewrite WeaveCrypto as a .jsm| to SeaMonkey

Categories

(SeaMonkey :: Build Config, defect, P4)

Tracking

(seamonkey2.9 wontfix, seamonkey2.10 wontfix, seamonkey2.11 fixed, seamonkey2.12 fixed)

RESOLVED FIXED
seamonkey2.13
Tracking Status
seamonkey2.9 --- wontfix
seamonkey2.10 --- wontfix
seamonkey2.11 --- fixed
seamonkey2.12 --- fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file)

      No description provided.
Flags: in-testsuite-
Attachment #627167 - Flags: review?(bugspam.Callek)
Attachment #627167 - Flags: approval-comm-beta?
Attachment #627167 - Flags: approval-comm-aurora?
Comment on attachment 627167 [details] [diff] [review]
(Av1) Update packaging after |Bug 562431 - Rewrite WeaveCrypto as a .jsm|
[Checked in: Comment 5 & 8]

Hrm, I don't see this corresponding removed-files change for any other product, are we *sure* this is correct? [clearing approval req's until that is answered]
Attachment #627167 - Flags: approval-comm-beta?
Attachment #627167 - Flags: approval-comm-aurora?
(In reply to Justin Wood (:Callek) from comment #2)
> Hrm, I don't see this corresponding removed-files change for any other
> product, are we *sure* this is correct?

Known: "Firefox" (at least) often just doesn't care about its removed-files.in :-/
I'm very sure: just check that this file is actually packaged in omni.ja.
Attachment #627167 - Flags: review?(bugspam.Callek) → review+
Attachment #627167 - Flags: approval-comm-beta?
Attachment #627167 - Flags: approval-comm-aurora?
Attachment #627167 - Flags: approval-comm-beta?
Attachment #627167 - Flags: approval-comm-beta+
Attachment #627167 - Flags: approval-comm-aurora?
Attachment #627167 - Flags: approval-comm-aurora+
There is a list of bugs I just approved for beta (though we're on our last beta now, with the release spinning friday or sat) which touch this same file (removed-files.in)

This is one of those bugs where I could not find a way to apply it to beta, even after mixing and matching the order here repeatedly.

Please either provide one monolithic patch which makes someones life easier, convince someone to untangle, tell us the order, or do it yourself. Otherwise I am comfortable with these slipping from this release.

I won't even attempt to land these patches on aurora for the same reasons without one of the above solutions being done.
Comment on attachment 627167 [details] [diff] [review]
(Av1) Update packaging after |Bug 562431 - Rewrite WeaveCrypto as a .jsm|
[Checked in: Comment 5 & 8]

http://hg.mozilla.org/comm-central/rev/23060289eeb3
Attachment #627167 - Attachment description: (Av1) Update packaging after |Bug 562431 - Rewrite WeaveCrypto as a .jsm| → (Av1) Update packaging after |Bug 562431 - Rewrite WeaveCrypto as a .jsm| [Checked in: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.12 → seamonkey2.13
(In reply to Justin Wood (:Callek) from comment #4)
> tell us the order

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> http://hg.mozilla.org/comm-central/rev/23060289eeb3

Please c-n the 6 changesets in
http://hg.mozilla.org/comm-central/pushloghtml?changeset=23060289eeb3
Keywords: checkin-needed
Whiteboard: [c-n (after bug 758575): comment 6 to c-a and c-b]
Comment on attachment 627167 [details] [diff] [review]
(Av1) Update packaging after |Bug 562431 - Rewrite WeaveCrypto as a .jsm|
[Checked in: Comment 5 & 8]

(In reply to Ryan VanderMeulen from comment #7)
> https://hg.mozilla.org/releases/comm-aurora/rev/74f15aee612b
> 
> https://hg.mozilla.org/releases/comm-beta/rev/8d7e4be7518d

These are the changesets for this bug.
Attachment #627167 - Attachment description: (Av1) Update packaging after |Bug 562431 - Rewrite WeaveCrypto as a .jsm| [Checked in: Comment 5] → (Av1) Update packaging after |Bug 562431 - Rewrite WeaveCrypto as a .jsm| [Checked in: Comment 5 & 8]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: