758574 - Port |Bug 662178 - Simplify timed callbacks| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Sync UI, defect)

Comment 1

[Philip Chee]

I think the only thing we need to do is:
http://hg.mozilla.org/mozilla-central/rev/f66e634eb6eb#l1.12

> -      Utils.delay(function () { f(items[i], cb); });
> +      Utils.nextTick(function () { f(items[i], cb); });

The rest is in toolkit. Jens is this still needed?

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Philip Chee from comment #1)
> I think the only thing we need to do is:
> http://hg.mozilla.org/mozilla-central/rev/f66e634eb6eb#l1.12
> 
> > -      Utils.delay(function () { f(items[i], cb); });
> > +      Utils.nextTick(function () { f(items[i], cb); });
> 
> The rest is in toolkit. Jens is this still needed?

[You quoted the wrong part, though the link is correct.]

Yes, still needed. Actually, I think our current code in syncQuota.js is broken. Looking at mozilla-central changeset f66e634eb6eb one would get the impression that delay() still existed, but somewhere between then and now, the namedTimer function declaration has been updated and "delay" been removed from it. So unless I'm mistaken, line 73 should throw an error right now.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

Comment 4

[[e-mail]]

Comment on attachment 826513 [details] [diff] [review]
patch

>       // The 'Weave' object will disappear once the window closes.
>       let Service = Weave.Service;
>+      Weave.Utils.nextTick(function() { Service.sync(); });
r=me as it is an exact port of the browser code and will make further porting easier, but I just wanted to point out that a better way to write this would be
Weave.Utils.nextTick(Weave.Service.sync, Weave.Service);

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

https://hg.mozilla.org/comm-central/rev/6e39f5e0dfd6