758583 - "ERROR: Potential deadlock detected" with mozCaptureStreamUntilEnded

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jesse Ruderman]

Attachment: testcase (assumes it is on jesse's computer)

1. Save the testcase.
2. Fix the path to point at your tree.
3. Load [your copy of the testcase] in a debug build of Firefox.
4. Quit Firefox with Cmd+Q.

Result: Deadlock assertions.


###!!! ERROR: Potential deadlock detected:
$ @@@ ###!!! ERROR: Potential deadlock detected:
=== Cyclical dependency starts at
--- Mutex : mozilla::media::SourceMediaStream calling context
stacks_disabled+0[stacks_disabled +0x0]

--- Next dependency:
--- Mutex : MediaStreamGraphImpl (currently acquired)
 calling context
stacks_disabled+0[stacks_disabled +0x0]

=== Cycle completed at
--- Mutex : mozilla::media::SourceMediaStream calling context
stacks_disabled+0[stacks_disabled +0x0]

Deadlock may happen for some other execution

###!!! ASSERTION: Potential deadlock detected:
$ @@@ ###!!! ASSERTION: Potential deadlock detected:
Cyclical dependency starts at
Mutex : mozilla::media::SourceMediaStream
Next dependency:
Mutex : MediaStreamGraphImpl (currently acquired)
Cycle completed at
Mutex : mozilla::media::SourceMediaStream
Deadlock may happen for some other execution

: 'Error', file BlockingResourceBase.cpp, line 128

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Not sure how to test this since it requires shutting down Firefox...

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfd001299d34

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cfd001299d34