758586 - Restart test fails when it's followed immediately by another test

Status: RESOLVED WORKSFORME

(Testing Graveyard :: Mozmill, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Manifest file to run restart test twice.

When a restart test is followed immediately by another test (either by specifying a directory with the tests, or by manifest file), the restart test fails with the following:

TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed
RESULTS | Passed: 2
RESULTS | Failed: 0
RESULTS | Skipped: 0
ERROR | Traceback (most recent call last):
ERROR |   File "/Users/dhunt/workspace/mozmill/master/mozmill/mozmill/__init__.py", line 647, in run
ERROR |     mozmill.run(*self.manifest.tests)
ERROR |   File "/Users/dhunt/workspace/mozmill/master/mozmill/mozmill/__init__.py", line 364, in run
ERROR |     self.run_tests(*tests)
ERROR |   File "/Users/dhunt/workspace/mozmill/master/mozmill/mozmill/__init__.py", line 333, in run_tests
ERROR |     self.run_test_file(frame, test['path'])
ERROR |   File "/Users/dhunt/workspace/mozmill/master/mozmill/mozmill/__init__.py", line 291, in run_test_file
ERROR |     frame.runTestFile(path, False, name)
ERROR |   File "/Users/dhunt/workspace/mozmill/master/jsbridge/jsbridge/jsobjects.py", line 68, in __getattr__
ERROR |     if name in self.__attributes__():
ERROR |   File "/Users/dhunt/workspace/mozmill/master/jsbridge/jsbridge/jsobjects.py", line 54, in __attributes__
ERROR |     return self._bridge_.describe(self._name_)['attributes']
ERROR |   File "/Users/dhunt/workspace/mozmill/master/jsbridge/jsbridge/network.py", line 197, in describe
ERROR |     return self.run(_uuid, 'bridge.describe('+', '.join([encoder.encode(_uuid), obj_name])+')')
ERROR |   File "/Users/dhunt/workspace/mozmill/master/jsbridge/jsbridge/network.py", line 154, in run
ERROR |     self.send(exec_string)
ERROR |   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/asyncore.py", line 365, in send
ERROR |     result = self.socket.send(data)
ERROR |   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 170, in _dummy
ERROR |     raise error(EBADF, 'Bad file descriptor')
ERROR | error: [Errno 9] Bad file descriptor

I have attached a manifest and example test.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Very simple restart test.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh wow. That should really be a blocker given that our plan is to always use manifests with Mozmill 2.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave can you please re-test if this is still valid? I did a couple of restart test fixes lately and this could have been fixed.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Closing as WORKSFORME as I'm no longer able to replicate this issue.