758648 - Flash plugins on 5/25/2012 Nightly crash on Gingerbread

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

The stack trace looks like this:

Program received signal SIGSEGV, Segmentation fault.
warning: .dynamic section for "/Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libflashplayer.so" is not at the expected address (wrong library or version mismatch?)
0xafd16104 in __libc_android_abort () from /Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libc.so
(gdb) bt
#0  0xafd16104 in __libc_android_abort () from /Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libc.so
#1  0xafd13b5c in dlfree () from /Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libc.so
#2  0xafd149b0 in free () from /Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libc.so
#3  0xafc009c6 in operator delete(void*) () from /Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libstdc++.so
#4  0x72c143c2 in SkDevice::~SkDevice (this=0x4c780880, __in_chrg=<optimized out>)
    at /Users/snorp/source/mozilla-central/gfx/skia/src/core/SkDevice.cpp:35
#5  0x72bfd368 in SkRefCnt::unref (this=0x4c780880) at ../../dist/include/skia/SkRefCnt.h:60
#6  0x72c0f428 in DeviceCM::~DeviceCM (this=0x47559880, __in_chrg=<optimized out>)
    at /Users/snorp/source/mozilla-central/gfx/skia/src/core/SkCanvas.cpp:89
#7  0x72c108de in SkCanvas::internalRestore (this=0x361168) at /Users/snorp/source/mozilla-central/gfx/skia/src/core/SkCanvas.cpp:814
#8  0x72c10910 in SkCanvas::~SkCanvas (this=0x361168, __in_chrg=<optimized out>) at /Users/snorp/source/mozilla-central/gfx/skia/src/core/SkCanvas.cpp:449
#9  0x72c1093c in SkCanvas::~SkCanvas (this=0x361168, __in_chrg=<optimized out>) at /Users/snorp/source/mozilla-central/gfx/skia/src/core/SkCanvas.cpp:454
#10 0x72a578aa in unref (this=<optimized out>) at /Users/snorp/source/mozilla-central/gfx/skia/include/core/SkRefCnt.h:60
#11 ~ANPCanvas (this=<optimized out>, __in_chrg=<optimized out>) at /Users/snorp/source/mozilla-central/other-licenses/skia-npapi/SkANP.h:63
#12 anp_deleteCanvas (canvas=0x361118) at /Users/snorp/source/mozilla-central/other-licenses/skia-npapi/ANPCanvas.cpp:35
#13 0x8153adc6 in ?? () from /Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libflashplayer.so
#14 0x8153adc6 in ?? () from /Users/snorp/moz-gdb/lib/HT04KHJ05698/system/lib/libflashplayer.so

Regression range 831ff2eb9a28 to 3871d6ca5fb2

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=831ff2eb9a28&tochange=3871d6ca5fb2

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

It looks like bug 746794 is the likely culprit. Testing a backout locally.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Backing out bug 746794 locally did fix the issue for me. Mike can you take care of backing that out?

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/034bbdc7b9c9

Comment 5

[Aaron Train [:aaronmt]]

WFM via HTC Nexus One (2.3.4) across the board, latest-flash install