Last Comment Bug 758735 - TestSettingsAPI.cpp:14:20: warning: ‘gFunction’ defined but not used [-Wunused-variable]
: TestSettingsAPI.cpp:14:20: warning: ‘gFunction’ defined but not used [-Wunuse...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla15
Assigned To: Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th)
:
Mentors:
Depends on:
Blocks: buildwarning 743336
  Show dependency treegraph
 
Reported: 2012-05-25 12:12 PDT by Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th)
Modified: 2012-05-26 05:21 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (808 bytes, patch)
2012-05-25 12:14 PDT, Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th)
anygregor: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-05-25 12:12:21 PDT
{
xpcom/tests/TestSettingsAPI.cpp:14:20: warning: ‘gFunction’ defined but not used [-Wunused-variable]
}

This file was added here:
  http://hg.mozilla.org/mozilla-central/rev/a0ec06f6c00d
with
> static const char* gFunction = "main";
as an unused variable.
Comment 1 Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-05-25 12:14:40 PDT
Created attachment 627316 [details] [diff] [review]
fix
Comment 2 Gregor Wagner [:gwagner] 2012-05-25 12:25:37 PDT
Comment on attachment 627316 [details] [diff] [review]
fix

Oh I thought this is needed for the test-environment. 
Thanks for fixing!
Comment 3 Daniel Holbert [:dholbert] (mostly OOTO until Aug 9th) 2012-05-25 12:31:17 PDT
(Nope -- it's used in a different test-file in the same directory just for logging purposes, not for any functional purpose.)

Thanks for the review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc62e10fe692
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-05-26 05:21:19 PDT
https://hg.mozilla.org/mozilla-central/rev/bc62e10fe692

Note You need to log in before you can comment on or make changes to this bug.