Cannot build in toolkit/xre any more!

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: joey)

Tracking

unspecified
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

$ make -C obj-ff-dbg/toolkit/xre
Makefile:230: *** Variable SOURCE_REPO does not contain a value.  Stop.

Gerv, has this been caused by your recent changes?
(Assignee)

Comment 1

5 years ago
(In reply to Ehsan Akhgari [:ehsan] from comment #0)
> $ make -C obj-ff-dbg/toolkit/xre
> Makefile:230: *** Variable SOURCE_REPO does not contain a value.  Stop.
> 
> Gerv, has this been caused by your recent changes?

Are you building within an hg sandbox ?  The error will be reported if 'hg showconfig' cannot obtain a value for $SOURCE_REPO (~line 264 in toolkit/xre/Makefile.in)
Joey, didn't we decide the goal was *NOT* to break local devs with your changes there.

And that if it did break local devs something was severely wrong and it needed redesign/backout?
(Assignee)

Comment 3

5 years ago
(In reply to Justin Wood (:Callek) from comment #2)
> Joey, didn't we decide the goal was *NOT* to break local devs with your
> changes there.
> 
> And that if it did break local devs something was severely wrong and it
> needed redesign/backout?

Similar content but I think this check/patch pre-dates that discussion.  Another bug is open for collecting revision control commands into a central include file and it was discussed there.

This is easy enough to revert or make conditional for o-fficial builds.
(Assignee)

Updated

5 years ago
Assignee: nobody → joey
(Assignee)

Comment 4

5 years ago
Created attachment 627344 [details] [diff] [review]
change SOURCE_REPO var check from error to warn.
(Assignee)

Comment 5

5 years ago
Comment on attachment 627344 [details] [diff] [review]
change SOURCE_REPO var check from error to warn.

Chaser job for bug # 688061
Morph SOURCE_REPO variable test from error to warn so building within a non-hg sandbox will not force failure.
Attachment #627344 - Flags: review?(khuey)
Attachment #627344 - Flags: review?(khuey) → review+
(In reply to Joey Armstrong [:joey] from comment #1)
> (In reply to Ehsan Akhgari [:ehsan] from comment #0)
> > $ make -C obj-ff-dbg/toolkit/xre
> > Makefile:230: *** Variable SOURCE_REPO does not contain a value.  Stop.
> > 
> > Gerv, has this been caused by your recent changes?
> 
> Are you building within an hg sandbox ?  The error will be reported if 'hg
> showconfig' cannot obtain a value for $SOURCE_REPO (~line 264 in
> toolkit/xre/Makefile.in)

I don't know what an hg sandbox is.  I use git, FWIW.  :-)
He means an hg checkout. :-)
Well, then, no.  hg is not involved at all in my build process.
(Assignee)

Comment 9

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=f4c6d3d41a94
https://hg.mozilla.org/mozilla-central/rev/728450b22631
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.