758748 - Cannot build in toolkit/xre any more!

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

$ make -C obj-ff-dbg/toolkit/xre
Makefile:230: *** Variable SOURCE_REPO does not contain a value.  Stop.

Gerv, has this been caused by your recent changes?

Comment 1

[Joey Armstrong [:joey]]

(In reply to Ehsan Akhgari [:ehsan] from comment #0)
> $ make -C obj-ff-dbg/toolkit/xre
> Makefile:230: *** Variable SOURCE_REPO does not contain a value.  Stop.
> 
> Gerv, has this been caused by your recent changes?

Are you building within an hg sandbox ?  The error will be reported if 'hg showconfig' cannot obtain a value for $SOURCE_REPO (~line 264 in toolkit/xre/Makefile.in)

Comment 2

[Justin Wood (:Callek)]

Joey, didn't we decide the goal was *NOT* to break local devs with your changes there.

And that if it did break local devs something was severely wrong and it needed redesign/backout?

Comment 3

[Joey Armstrong [:joey]]

(In reply to Justin Wood (:Callek) from comment #2)
> Joey, didn't we decide the goal was *NOT* to break local devs with your
> changes there.
> 
> And that if it did break local devs something was severely wrong and it
> needed redesign/backout?

Similar content but I think this check/patch pre-dates that discussion.  Another bug is open for collecting revision control commands into a central include file and it was discussed there.

This is easy enough to revert or make conditional for o-fficial builds.

Comment 4

[Joey Armstrong [:joey]]

Attachment: change SOURCE_REPO var check from error to warn.

Comment 5

[Joey Armstrong [:joey]]

Comment on attachment 627344 [details] [diff] [review]
change SOURCE_REPO var check from error to warn.

Chaser job for bug # 688061
Morph SOURCE_REPO variable test from error to warn so building within a non-hg sandbox will not force failure.

Comment 6

[(no longer active)]

(In reply to Joey Armstrong [:joey] from comment #1)
> (In reply to Ehsan Akhgari [:ehsan] from comment #0)
> > $ make -C obj-ff-dbg/toolkit/xre
> > Makefile:230: *** Variable SOURCE_REPO does not contain a value.  Stop.
> > 
> > Gerv, has this been caused by your recent changes?
> 
> Are you building within an hg sandbox ?  The error will be reported if 'hg
> showconfig' cannot obtain a value for $SOURCE_REPO (~line 264 in
> toolkit/xre/Makefile.in)

I don't know what an hg sandbox is.  I use git, FWIW.  :-)

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

He means an hg checkout. :-)

Comment 8

[(no longer active)]

Well, then, no.  hg is not involved at all in my build process.

Comment 9

[Joey Armstrong [:joey]]

https://tbpl.mozilla.org/?tree=Try&rev=f4c6d3d41a94

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/728450b22631