758792 - Robocop: getActivityFromClick can hang on waitForIdleSync

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

Intense testing (repeated testCheck/2/3) and logging shows that BaseTest.getActivityFromClick sometimes hangs during one or the other call to waitForIdleSync. Removing either call causes other problems, but replacing each with a sleep() call improves reliability considerably.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: remove waitForIdleSync calls in getActivityFromClick

Simple change: replace 2 waitForIdleSync calls in getActivityFromClick with sleep calls that wait for about the maximum observed wait time spent in waitForIdleSync.

Of course I am uncomfortable introducing additional sleep calls with little justification. However the observed benefit is undeniable, and the waitForIdleSync calls were already a hack, IMO, in that we don't really understand what waitForIdleSync does.

We call waitForIdleSync in a couple of other places, but I have not observed any problems related to those calls, so have not changed those.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 627829 [details] [diff] [review]
remove waitForIdleSync calls in getActivityFromClick

Review of attachment 627829 [details] [diff] [review]:
-----------------------------------------------------------------

can we put some comments in describing that waitForIdleSync was not working as expected and this seems to be the most effective way to get the tests to run and pass?  I would like to put a followup bug in to address the sleep stuff in general.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: remove waitForIdleSync calls in getActivityFromClick

Updated comments. r=jmaher carried.

Comment 4

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3b1df7ffdab

Comment 5

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/c3b1df7ffdab