758838 - DeviceStorage.enumerate() doesn't work

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Flanagan [:djf]]

I can use the new DeviceStorage API to add files to ~/Pictures on my mac, but I cannot enumerate the files in ~/Pictures or its subdirectories.

I'm testing this in a Gaia app in the b2g desktop client on MacOS.

My test code looks like this:

var storage = navigator.getDeviceStorage("pictures")[0];
var cursor = storage.enumerate("test");
cursor.onsuccess = function(e) {
  var r = e.target.result;
  console.log("cursor success:", r, r?r.name:"");
  if (cursor.result)
    e.target.continue();
};

There are files in ~/Pictures/test/ (including one created with the Device storage API) but the onsuccess handler is never called.

Comment 1

[Doug Turner (:dougt)]

i can look next week.

in the mean time, we know that enumeration does work cross platform - 

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/devicestorage/test_enumerate.html?force=1

It must be something w/ the pictures directory...

Comment 2

[Doug Turner (:dougt)]

 please add a onerror handler.  e.target.error.name will tell you a bunch.

Comment 3

[David Flanagan [:djf]]

I've been using an onerror, but took it out in the code I quoted above.  It never gets called.  See the code in context here: 

https://github.com/davidflanagan/gaia/blob/ds/apps/gallery/js/gallery.js#L138

Comment 4

[Doug Turner (:dougt)]

cursor.onerror = function(e) {
  console.log("enumerate error", cursor.error.name);
}

cursor.error.name will probably throw, right?

Comment 5

[David Flanagan [:djf]]

(In reply to Doug Turner (:dougt) from comment #4)
> cursor.onerror = function(e) {
>   console.log("enumerate error", cursor.error.name);
> }
> 
> cursor.error.name will probably throw, right?

You told me to look at e.target.error.name.  Given that the event target is the cursor, isn't e.target always the same as cursor?

In any case, I've never seen the onerror event fire, even when all I do is console.log("error!")

Comment 6

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 7

[David Flanagan [:djf]]

With that attachment applied, enumerate() now works for me.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 628107 [details] [diff] [review]
patch v.1

Review of attachment 628107 [details] [diff] [review]:
-----------------------------------------------------------------

I probably just move all of the prompt bits into this new class.  but I can do that later, i suppose.

Comment 9

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b16fea69517

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2b16fea69517