Closed
Bug 758864
Opened 13 years ago
Closed 13 years ago
If no destination folder is given for the installer on Windows use a sub folder
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
Right now we always take the src folder as destination if it hasn't been specified. This works fine on OS X and Linux but is absolutely not the right solution on Windows. On that platform no new sub folder is created and the installer installs the application into the current folder. This clutters the src folder and also makes it not possible to uninstall the application on Windows.
|
Assignee | |
Comment 1•13 years ago
|
||
This only affects the installer on Windows but not the zip file.
Summary: If no destination folder is given for mozinstaller on Windows don't clutter the src folder → If no destination folder is given for the installer on Windows use a sub folder
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 627510 [details]
Patch v1
Improves the installer code for handling all sort of installable packages. Also fixes some other bugs in correctly handling exceptions and invalid conditions.
Attachment #627510 -
Attachment description: Pointer to Github pull request: https://github.com/mozilla/mozbase/pull/15 → Patch v1
Attachment #627510 -
Flags: review?(ctalbert)
Comment on attachment 627510 [details]
Patch v1
r+
Attachment #627510 -
Flags: review?(ctalbert) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•