75893 - crash printing this and a lot of other sites.

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[hirata masakazu]

2001041212 Mac trunk.
Even though bug 74083 is now WFM, this URL page crashes before Mozilla starts to
send data to printer driver.
Steps to reproduce:
Goto URL
Print
(Just print entire document without any option)
Result:crash.

Comment 1

[hirata masakazu]

Attachment: stack trace of the crash trying to print this URL

Comment 2

[hirata masakazu]

I am crashing trying to print various pages at CNN.com, wasingtonpost.com, etc
with the same stack trace.

Comment 3

[hirata masakazu]

nominating for 0.9, adding crash keyword

Comment 4

[dcone (gone)]

I can reproduce on the Mac.. but.. the "and a lot of other sites." does not 
help. What are these sites.. do they have things in common.  Are they top 100 
sites. That would help in the disposition of this bug.  Currently. it blows up 
deep in layout, I have not a clue where.. and the url is huge. the test case 
needs to be minimized

Comment 5

[hirata masakazu]

The URLs that crash when printed:
http://www.cnn.com
http://www.boston.com
http://www.ncbi.nlm.nih.gov/Entrez/medline.html
http://espn.go.com
http://www.news.com

The URLs that do not:
http://news.bbc.co.uk
http://bugzilla.mozilla.org
http://www.yahoo.com
http://www.christopherlydon.org
http://www.email.com
http://www.mozillazine.org

Comment 6

[hirata masakazu]

Attachment: stack trace when FaxStf's preview was used instead of LaserWriter

Comment 7

[hirata masakazu]

Actually, http://news.bbc.co.uk does crash, if I try to print using FaxStf
insted of LaserWriter.(see the stack trace)
When printed using LaserWriter, news.bbc.co.uk comes out as mostly blank, with
only the footer (not HTML footer) and the column of right side in the second page.

Comment 8

[hirata masakazu]

I can generalize the problem like this:
1.Printing crahses in various sites with tables.
2.If it does not crash (http://news.bbc.co.uk, http://www.fifa.com), the main
text and a lot of the content are not printed.  This may be a separate bug or
the same bug.
3.The crash using preview of Faxstf is a separate bug, since USA Today crashes
in both Faxstf and LW with different timing and stack traces.

Comment 9

[dcone (gone)]

Thanks for the Info.. this helps alot

Comment 10

[dcone (gone)]

*** Bug 76637 has been marked as a duplicate of this bug. ***

Comment 11

[Asa Dotzler [:asa]]

unsetting Target Milestone, adding nomination keyword.  Nominating is done with
Keywords, not Target Milestone.  Target Milestone is used by the developer to
communicate the development cycle in which he intends to fix the problem.

Comment 12

[Kevin McCluskey (gone)]

Setting target milestone to mozilla0.9. This is Don's top priority.

Comment 13

[dcone (gone)]

Attachment: part 1 patch

Comment 14

[dcone (gone)]

Attachment: part 2 of patch

Comment 15

[dcone (gone)]

Attachment: Part 3 of patch

Comment 16

[Marc Attinasi]

Please fix the tabs in nsSimplePageSequence.cpp, and comment about the mSpec
magic in the DeviceContextMac stuff. Also, what testing have you done? sr=attinasi.

Comment 17

[Kevin McCluskey (gone)]

In patch1 could you just remove this code instead of removing 1 line and 
leaving the rest of the code commented out. The remaining code will be confusing 
to look at.

//if (nsnull == mSurface)
-    aSupportsWidgets = PR_TRUE;
+    
   //else
    //aSupportsWidgets = PR_FALSE;



Please add a NS_WARNING when EndPage indicates a failure.

 if(mSkipPageEnd){
+
    PRINT_DEBUG_MSG1("***************** End Page (DoPageEnd) *****************\n");
+
    nsresult rv = dc->EndPage();
+
    if (NS_FAILED(rv)) {
+
      return rv;
+
    }



Please fix tab/spacing on the patches
With the above changes r=[e-mail]

Comment 18

[chris hofmann]

a=chofmann

Comment 19

[dcone (gone)]

Checked in all the fixes for this.  Framesets will now print, and the sites with 
comboboxes should now work.  Also Frameset pages could go into an endless loop 
with will no longer happen.  Much improvement on the Mac with these fixes.

Comment 20

[hirata masakazu]

verified. But, it is not printing properly yet. Another bug, I guess.

Comment 21

[Roland Mainz]

hirata masakazu: Did you mean the issue described in bug 77733 ?