Is Spdy VerifyStream() needed?

RESOLVED FIXED in mozilla17

Status

()

Core
Networking: HTTP
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

unspecified
mozilla17
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

([spdy])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
bug 753663 tracked a crash where a invalid spdy stream was used.. generally under the signature mozilla::net::SpdyStream::UpdateTransportReadEvents 

the source of the crash has never been fully understood.

bug 756551 fixed that crash through a series of integrity checks and theoretically un-needed intializations.

when we have a full nightly window we should change VerifyStream() to be DEBUG only and see if the crashes have been genuinely fixed or not via nightly crash stats. (we can expect about 1 a day on nightly.. 4+ or so with a current sized aurora audience).
(Assignee)

Comment 1

5 years ago
I believe 759438 was the underlying cause of the corruption.

Given that we have a fresh nightly cycle I think we should turn VerifyStream() into a DEBUG-build only feature and look for regressions in crash stats.
Status: NEW → ASSIGNED
Depends on: 759438
(Assignee)

Comment 2

5 years ago
Created attachment 643879 [details] [diff] [review]
patch 0
Attachment #643879 - Flags: review?(honzab.moz)
Comment on attachment 643879 [details] [diff] [review]
patch 0

Review of attachment 643879 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/SpdySession3.cpp
@@ +704,5 @@
> +#ifndef DEBUG
> +  // Only do the real verification in debug builds
> +  return true;
> +#endif
> +  fprintf(stderr,"VERIFY\n");

fprintf leftover?
Attachment #643879 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Honza Bambas (:mayhemer) from comment #3)

> 
> fprintf leftover?

doh! thanks.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/43f259b15ccc
Target Milestone: mozilla16 → mozilla17
https://hg.mozilla.org/mozilla-central/rev/43f259b15ccc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.