758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

This warning generates ridiculous amount of spam and isn't really useful.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 627594 [details] [diff] [review]
Patch

Review of attachment 627594 [details] [diff] [review]:
-----------------------------------------------------------------

Punting to njn or espindola, who care about warning flags and clang. Whoever reviews it first wins!

Comment 2

[Jacek Caban]

Ted(In reply to Ted Mielczarek [:ted] from comment #1)
> Comment on attachment 627594 [details] [diff] [review]
> Patch
> 
> Review of attachment 627594 [details] [diff] [review]:

Recent GCCs also support these warnings, with the same arguments syntax. I think it would be better to set it for all GCC-like compilers using MOZ_CXX_SUPPORTS_WARNING, like in other similar cases.

Comment 3

[Jacek Caban]

(In reply to Jacek Caban from comment #2)
> Recent GCCs also support these warnings, with the same arguments syntax. I
> think it would be better to set it for all GCC-like compilers using
> MOZ_CXX_SUPPORTS_WARNING, like in other similar cases.

Nevetmind that, I confused that with -Wno-delete-non-virtual-dtor, sorry about that. Anyway, with MOZ_CXX_SUPPORTS_WARNING we wouldn't need to hardcode the logic about which compiler supports which exact flags.

Comment 4

[Gregory Szorc [:gps]]

What do you mean it isn't really useful? I thought it was a best practice to make destructors virtual because if you call delete with a non-virtual dtor, the dtor for the type of the pointer gets called, not necessarily the type of the underlying object. I could be wrong: my C++ are far from expert level. FWIW http://www.parashift.com/c++-faq-lite/virtual-functions.html#faq-20.7 seems to agree with me. Furthermore, the Clang warning seems to enforce the recommended behavior according to that FAQ.

While there may be many places in the code where not having virtual dtors is OK, you are requesting a global change. This could silence legitimate warnings and lead to memory leaks, etc.

Am I missing something obvious?

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 627594 [details] [diff] [review]
Patch

Same opinion as Gregory Szorc. This warning already found real bugs for me. We were deleting an interface if I remember correctly.

In most cases, the simplest fix is to mark a class final, which also makes it more likely that the compiler will be able to remove virtual calls.

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 627594 [details] [diff] [review]
Patch

I don't have strong opinions on clang-only flags.

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 627594 [details] [diff] [review]
Patch

Ugh, I mangled the review flags.  Sorry.

Comment 8

[(no longer active)]

The right way to fix this is to mark the classes which generate this type of warning as MOZ_FINAL.

Comment 9

[(no longer active)]

Attachment: XPCOM parts

Comment 10

[(no longer active)]

Attachment: chrome/ parts

Comment 11

[(no longer active)]

Attachment: libpref parts

Comment 12

[(no longer active)]

Attachment: intl/ parts

Comment 13

[(no longer active)]

Attachment: netwerk parts

Comment 14

[(no longer active)]

With the patches so far: https://tbpl.mozilla.org/?tree=Try&rev=979b9939f26b

Comment 15

[Benjamin Smedberg]

Comment on attachment 630370 [details] [diff] [review]
XPCOM parts

Is MOZ_FINAL being enforced by tinderboxes? I think this is ugly but potentially useful, but don't think we should add these aannotations unless they are being enforced.

Comment 16

[(no longer active)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #15)
> Comment on attachment 630370 [details] [diff] [review]
> XPCOM parts
> 
> Is MOZ_FINAL being enforced by tinderboxes? I think this is ugly but
> potentially useful, but don't think we should add these aannotations unless
> they are being enforced.

They are currently enforced by MSVC (where MOZ_FINAL will get converted to "sealed"), and they will be enforced by clang as well as soon as we get them up (Real Soon Now).  For gcc on Linux, this will be enforced when we switch to gcc 4.7.

In the mean time, this work cleans up the thousands of warnings that people see in their local builds, and will help them notice real bugs where this warning is not issued because of the way we implement XPCOM classes (I've already noticed a couple of these locations -- will file bugs on them shortly).

Comment 17

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 630427 [details] [diff] [review]
netwerk parts

Going to punt this one to jduell.

Comment 18

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3b12cb2c877
https://hg.mozilla.org/integration/mozilla-inbound/rev/604347b8d215
https://hg.mozilla.org/integration/mozilla-inbound/rev/215768269808

Comment 19

[(no longer active)]

Comment on attachment 630415 [details] [diff] [review]
intl/ parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/55329a11e8d1

Comment 20

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/d3b12cb2c877
https://hg.mozilla.org/mozilla-central/rev/604347b8d215
https://hg.mozilla.org/mozilla-central/rev/215768269808
https://hg.mozilla.org/mozilla-central/rev/55329a11e8d1

Comment 21

[(no longer active)]

Attachment: More xpcom parts

Missed these in the previous patch.

Comment 22

[(no longer active)]

Attachment: extensions/auth parts

Comment 23

[(no longer active)]

Attachment: xpconnect parts

Comment 24

[(no longer active)]

Attachment: libjar parts

Comment 25

[(no longer active)]

Attachment: storage parts

Comment 26

[(no longer active)]

Attachment: extensions/permissions parts

Comment 27

[(no longer active)]

Attachment: rdf(!!!) parts

I never thought I'd touch the rdf directory.  <sigh>

Comment 28

[(no longer active)]

Attachment: jsd parts

Comment 29

[(no longer active)]

Attachment: uriloader parts

Comment 30

[(no longer active)]

Attachment: caps parts

Comment 31

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 632531 [details] [diff] [review]
uriloader parts

r=me

Comment 32

[(no longer active)]

Attachment: parser parts

Comment 33

[(no longer active)]

Attachment: gfx parts

Comment 34

[(no longer active)]

Attachment: imagelib parts

Comment 35

[(no longer active)]

Comment on attachment 632531 [details] [diff] [review]
uriloader parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/4142308ec401

Comment 36

[Jacek Caban]

Attachment: widget/windows part

widget/windows parts found by mingw compilation. Other than just marking classes as final, required changing nsDataObjCollection destructor to be virtual.

Comment 37

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/d3b12cb2c877
https://hg.mozilla.org/mozilla-central/rev/604347b8d215
https://hg.mozilla.org/mozilla-central/rev/215768269808
https://hg.mozilla.org/mozilla-central/rev/55329a11e8d1

Comment 38

[(no longer active)]

Comment on attachment 630427 [details] [diff] [review]
netwerk parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/866b1639131d

Comment 39

[(no longer active)]

Comment on attachment 632521 [details] [diff] [review]
xpconnect parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd7e4d5c8f2

Comment 40

[(no longer active)]

Comment on attachment 632533 [details] [diff] [review]
caps parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/32ddf13b1d3a

Comment 41

[(no longer active)]

Comment on attachment 632535 [details] [diff] [review]
parser parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/c755cdaa7dbc

Comment 42

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4142308ec401

Comment 43

[(no longer active)]

Comment on attachment 632539 [details] [diff] [review]
gfx parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ebf9b40ce02

Comment 44

[(no longer active)]

Comment on attachment 632540 [details] [diff] [review]
imagelib parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccfe8a6a3533

Comment 45

[(no longer active)]

Comment on attachment 632522 [details] [diff] [review]
libjar parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/584ae96f6c95

Comment 46

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/866b1639131d
https://hg.mozilla.org/mozilla-central/rev/3dd7e4d5c8f2
https://hg.mozilla.org/mozilla-central/rev/32ddf13b1d3a
https://hg.mozilla.org/mozilla-central/rev/c755cdaa7dbc

Comment 47

[(no longer active)]

Comment on attachment 632525 [details] [diff] [review]
storage parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b34c182b276

Comment 48

[(no longer active)]

Comment on attachment 632530 [details] [diff] [review]
jsd parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/2da255c1aeb9

Comment 49

[Jacek Caban]

Attachment: widget/windows part

updated version

Comment 50

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5ebf9b40ce02
https://hg.mozilla.org/mozilla-central/rev/ccfe8a6a3533
https://hg.mozilla.org/mozilla-central/rev/584ae96f6c95
https://hg.mozilla.org/mozilla-central/rev/8b34c182b276
https://hg.mozilla.org/mozilla-central/rev/2da255c1aeb9

Comment 51

[(no longer active)]

Comment on attachment 632516 [details] [diff] [review]
More xpcom parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/80e7e9a4dbaf

Comment 52

[(no longer active)]

Comment on attachment 632517 [details] [diff] [review]
extensions/auth parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/df550e51189f

Comment 53

[(no longer active)]

Comment on attachment 632527 [details] [diff] [review]
extensions/permissions parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e6998d64114

Comment 54

[(no longer active)]

Comment on attachment 632529 [details] [diff] [review]
rdf(!!!) parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8008a0ab81

Comment 55

[(no longer active)]

Comment on attachment 633074 [details] [diff] [review]
widget/windows part

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ac5b95215d2

Comment 56

[(no longer active)]

Attachment: More uriloader parts

Comment 57

[(no longer active)]

Attachment: dom parts

Comment 58

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 633358 [details] [diff] [review]
More uriloader parts

r=me

Comment 59

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 633373 [details] [diff] [review]
dom parts

1) Making nswebNavigationBaseCommand final makes no sense.

2) For some of the places where you put isupports on all subclasses, wouldn't just putting a virtual destructor on the superclass make more sense?

3) You changed FileInputStreamWrapper and FileOutputStreamWrapper to non-threadsafe refcounting.  Why?  Seems wrong at first glance.

r=me with #1 and #3 fixed and #2 at least considered.

Comment 60

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/80e7e9a4dbaf
https://hg.mozilla.org/mozilla-central/rev/df550e51189f
https://hg.mozilla.org/mozilla-central/rev/4e6998d64114
https://hg.mozilla.org/mozilla-central/rev/7d8008a0ab81
https://hg.mozilla.org/mozilla-central/rev/6ac5b95215d2

Comment 61

[(no longer active)]

Comment on attachment 633358 [details] [diff] [review]
More uriloader parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c4309dce383

Comment 62

[(no longer active)]

Comment on attachment 633373 [details] [diff] [review]
dom parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/01f3e0c756b0 (with all of the comments addressed)

Comment 63

[(no longer active)]

Attachment: More dom parts

Comment 64

[(no longer active)]

Attachment: view parts

Comment 65

[(no longer active)]

Attachment: widget parts

Comment 66

[(no longer active)]

Attachment: content parts

Note that I intentionally didn't mark the nsBindingManager as final because of http://llvm.org/bugs/show_bug.cgi?id=13142.

Comment 67

[(no longer active)]

Attachment: layout parts

Comment 68

[(no longer active)]

Attachment: layout parts

GenericTableRule does have derived classes...

Comment 69

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 634280 [details] [diff] [review]
content parts

nsXULElement.cpp is including Attributes.h twice.  No need for that.

r=me modulo that nit.

Comment 70

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 634262 [details] [diff] [review]
More dom parts

r=me

Comment 71

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6c4309dce383
https://hg.mozilla.org/mozilla-central/rev/01f3e0c756b0

Comment 72

[(no longer active)]

Comment on attachment 634262 [details] [diff] [review]
More dom parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d826056332b

Comment 73

[(no longer active)]

Comment on attachment 634263 [details] [diff] [review]
view parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/4708cba2757d

Comment 74

[(no longer active)]

Comment on attachment 634265 [details] [diff] [review]
widget parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/97bbf868d76d

Comment 75

[(no longer active)]

Comment on attachment 634280 [details] [diff] [review]
content parts

Landed with the nit addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/6ea80e3155b6

Comment 76

[(no longer active)]

Comment on attachment 634284 [details] [diff] [review]
layout parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/823dc103bf3e

Comment 77

[(no longer active)]

Attachment: browser parts

Comment 78

[(no longer active)]

Attachment: toolkit parts

Comment 79

[(no longer active)]

Attachment: More widget parts

Comment 80

[(no longer active)]

Attachment: more storage parts

Comment 81

[(no longer active)]

Attachment: more xpconnect parts

Comment 82

[(no longer active)]

Attachment: More xpcom parts

Comment 83

[(no longer active)]

Attachment: more jsd parts

Comment 84

[(no longer active)]

Attachment: startupcache parts

Comment 85

[(no longer active)]

Attachment: xre parts

Comment 86

[(no longer active)]

Attachment: toolkit/profile parts

Comment 87

[(no longer active)]

Attachment: places parts

Comment 88

[(no longer active)]

Attachment: url-classifier parts

Comment 89

[(no longer active)]

Comment on attachment 634731 [details] [diff] [review]
More widget parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/58f066791aa7

Comment 90

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d826056332b
https://hg.mozilla.org/mozilla-central/rev/4708cba2757d
https://hg.mozilla.org/mozilla-central/rev/97bbf868d76d
https://hg.mozilla.org/mozilla-central/rev/6ea80e3155b6
https://hg.mozilla.org/mozilla-central/rev/823dc103bf3e
https://hg.mozilla.org/mozilla-central/rev/58f066791aa7

Comment 91

[(no longer active)]

Comment on attachment 634735 [details] [diff] [review]
more xpconnect parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/4420c2388936

Comment 92

[(no longer active)]

Comment on attachment 634745 [details] [diff] [review]
url-classifier parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e2df51374c0

Comment 93

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4420c2388936
https://hg.mozilla.org/mozilla-central/rev/0e2df51374c0

Comment 94

[(no longer active)]

Comment on attachment 634740 [details] [diff] [review]
more jsd parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/87d73e4f93f4

Comment 95

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87d73e4f93f4

Comment 96

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 634739 [details] [diff] [review]
More xpcom parts

Drive by r+. There's some gonk stuff that snuck in here.

Comment 97

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 634729 [details] [diff] [review]
browser parts

More drive by

Comment 98

[(no longer active)]

Comment on attachment 634729 [details] [diff] [review]
browser parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/76e0145803ba

Comment 99

[(no longer active)]

Comment on attachment 634730 [details] [diff] [review]
toolkit parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5ca1456419a

Comment 100

[(no longer active)]

Comment on attachment 634739 [details] [diff] [review]
More xpcom parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/debdfc7a3de8

Comment 101

[(no longer active)]

Comment on attachment 634741 [details] [diff] [review]
startupcache parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8a77e238f0

Comment 102

[(no longer active)]

Comment on attachment 634742 [details] [diff] [review]
xre parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/952cd748c30e

Comment 103

[(no longer active)]

Comment on attachment 634743 [details] [diff] [review]
toolkit/profile parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/a10f431c3480

Comment 104

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76e0145803ba
https://hg.mozilla.org/mozilla-central/rev/c5ca1456419a
https://hg.mozilla.org/mozilla-central/rev/debdfc7a3de8
https://hg.mozilla.org/mozilla-central/rev/bf8a77e238f0
https://hg.mozilla.org/mozilla-central/rev/952cd748c30e
https://hg.mozilla.org/mozilla-central/rev/a10f431c3480

Comment 105

[(no longer active)]

Comment on attachment 634733 [details] [diff] [review]
more storage parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f6369338673

Comment 106

[(no longer active)]

Comment on attachment 634744 [details] [diff] [review]
places parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c9fe7a8d3d

Comment 107

[(no longer active)]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/5c2e6a50906a to fix a bustage on Windows because class Spinner derives from AsyncStatementSpinner on Windows.

Comment 108

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f6369338673
https://hg.mozilla.org/mozilla-central/rev/d9c9fe7a8d3d
https://hg.mozilla.org/mozilla-central/rev/5c2e6a50906a

Comment 109

[(no longer active)]

Attachment: embedding parts

Comment 110

[(no longer active)]

Attachment: docshell parts

Comment 111

[(no longer active)]

Attachment: more layout parts

Comment 112

[(no longer active)]

Attachment: more content parts

Comment 113

[(no longer active)]

Attachment: More dom parts

Comment 114

[(no longer active)]

Comment on attachment 640903 [details] [diff] [review]
more layout parts

http://hg.mozilla.org/integration/mozilla-inbound/rev/e96d5a1428bc

Comment 115

[(no longer active)]

Comment on attachment 640901 [details] [diff] [review]
embedding parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d66a78f6130

Comment 116

[David Zbarsky (:dzbarsky)]

Attachment: extensions/cookie

Comment 117

[David Zbarsky (:dzbarsky)]

Attachment: toolkit/components/places

Comment 118

[David Zbarsky (:dzbarsky)]

Attachment: toolkit/components/url-classifier

Comment 119

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e96d5a1428bc
https://hg.mozilla.org/mozilla-central/rev/0d66a78f6130

Comment 120

[(no longer active)]

Comment on attachment 640934 [details] [diff] [review]
extensions/cookie

Throwing this at Marco!

Comment 121

[(no longer active)]

Comment on attachment 640934 [details] [diff] [review]
extensions/cookie

https://hg.mozilla.org/integration/mozilla-inbound/rev/75657697cfb5

Comment 122

[(no longer active)]

Comment on attachment 640935 [details] [diff] [review]
toolkit/components/places

https://hg.mozilla.org/integration/mozilla-inbound/rev/67e09e165ce6

Comment 123

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75657697cfb5
https://hg.mozilla.org/mozilla-central/rev/67e09e165ce6

Comment 124

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 640902 [details] [diff] [review]
docshell parts

r=me, and a blanket r=me on any changes to this bug that just look like this.  Please do ask for review if the change involves adding actual virtual destructors or doing anything more complicated, though, ok?

Comment 125

[(no longer active)]

(In reply to comment #124)
> r=me, and a blanket r=me on any changes to this bug that just look like this. 
> Please do ask for review if the change involves adding actual virtual
> destructors or doing anything more complicated, though, ok?

Absolutely!

Comment 126

[(no longer active)]

Comment on attachment 640902 [details] [diff] [review]
docshell parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/486769aaada1

Comment 127

[(no longer active)]

Comment on attachment 640904 [details] [diff] [review]
more content parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/add2eb6c9b6c

Comment 128

[(no longer active)]

Comment on attachment 640905 [details] [diff] [review]
More dom parts

https://hg.mozilla.org/integration/mozilla-inbound/rev/e53020fab4a1

Comment 129

[(no longer active)]

Comment on attachment 640936 [details] [diff] [review]
toolkit/components/url-classifier

https://hg.mozilla.org/integration/mozilla-inbound/rev/08b872de0676

Comment 130

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/486769aaada1
https://hg.mozilla.org/mozilla-central/rev/add2eb6c9b6c
https://hg.mozilla.org/mozilla-central/rev/e53020fab4a1
https://hg.mozilla.org/mozilla-central/rev/08b872de0676

Comment 131

[(no longer active)]

More xpcom parts: http://hg.mozilla.org/integration/mozilla-inbound/rev/82e6dc758859

Comment 132

[(no longer active)]

More toolkit parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/d58b34ab81fe

Comment 133

[(no longer active)]

security parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/27015626db13
spellchecker parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/81d4d1a93655
tools/profiler parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/5c0899d7ac49
accessibility parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/470febf38749
xpfe/appshell parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/06c8300c9a39

Comment 134

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/82e6dc758859
https://hg.mozilla.org/mozilla-central/rev/d58b34ab81fe
https://hg.mozilla.org/mozilla-central/rev/27015626db13
https://hg.mozilla.org/mozilla-central/rev/81d4d1a93655
https://hg.mozilla.org/mozilla-central/rev/5c0899d7ac49
https://hg.mozilla.org/mozilla-central/rev/470febf38749
https://hg.mozilla.org/mozilla-central/rev/06c8300c9a39

Comment 135

[(no longer active)]

gnome parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/7b3328b25a8d
more toolkit parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb030d799dd2
more xpfe/appshell parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/bae6464a3431

Comment 136

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7b3328b25a8d
https://hg.mozilla.org/mozilla-central/rev/eb030d799dd2
https://hg.mozilla.org/mozilla-central/rev/bae6464a3431

Comment 137

[(no longer active)]

more widget parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/af1332080768
ipc parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/fdd99385caaf
more intl parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/e76fcfc70316
more xpcom parts: https://hg.mozilla.org/integration/mozilla-inbound/rev/221933d494d3

Comment 138

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/af1332080768
https://hg.mozilla.org/mozilla-central/rev/fdd99385caaf
https://hg.mozilla.org/mozilla-central/rev/e76fcfc70316
https://hg.mozilla.org/mozilla-central/rev/221933d494d3

Comment 139

[(no longer active)]

This is fixed now as far as I can tell!

Comment 140

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/211b0801c67d

Comment 141

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/211b0801c67d