759040 - In nsHttpChannel, call mCacheAsyncFunc directly from ReadFromCache instead of dispatching an asynchronous event

Status: NEW

(Core :: Networking: HTTP, defect, P5)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

AFAICT, we should be able to call mCacheAsyncFunc directly, instead of calling it through AsyncCall(mCacheAsyncFunc), at least in most situations. This should speed things up by avoiding the need to wait for the main thread event queue to be cleared before calling mCacheAsyncFunc.

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.

Comment 4

[Valentin Gosu [:valentin]]

https://searchfox.org/firefox-main/rev/d0ff31da7cb418d2d86b0d83fecd7114395e5d46/netwerk/protocol/http/nsHttpChannel.cpp#5536-5550

  // TODO: Bug 759040 - We should call HandleAsyncRedirect directly here,
  // to avoid event dispatching latency.
  MOZ_ASSERT(!mCacheInputStream);
  LOG(("Skipping skip read of cached redirect entity\n"));
  return AsyncCall(&nsHttpChannel::HandleAsyncRedirect);
}

if ((mLoadFlags & LOAD_ONLY_IF_MODIFIED) && !LoadCachedContentIsPartial()) {
  LOG(
      ("Skipping read from cache based on LOAD_ONLY_IF_MODIFIED "
       "load flag\n"));
  MOZ_ASSERT(!mCacheInputStream);
  // TODO: Bug 759040 - We should call HandleAsyncNotModified directly
  // here, to avoid event dispatching latency.
  return AsyncCall(&nsHttpChannel::HandleAsyncNotModified);