Last Comment Bug 759063 - toolkit/xre Windows tests link to unneeded updatecommon lib
: toolkit/xre Windows tests link to unneeded updatecommon lib
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Jacek Caban
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: bgupdates
  Show dependency treegraph
 
Reported: 2012-05-28 02:44 PDT by Jacek Caban
Modified: 2012-05-30 07:40 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (747 bytes, patch)
2012-05-28 02:44 PDT, Jacek Caban
ehsan: review+
Details | Diff | Splinter Review

Description Jacek Caban 2012-05-28 02:44:44 PDT
Created attachment 627643 [details] [diff] [review]
fix v1.0

Makefile.in change was introduced by bug 307181, butAFAICS it's not needed there. Try run confirms that:

https://tbpl.mozilla.org/?tree=Try&rev=eac75d4f7ea4

(It causes problems with my mingw builds, that have updater disabled).
Comment 1 :Ehsan Akhgari 2012-05-29 15:00:55 PDT
Comment on attachment 627643 [details] [diff] [review]
fix v1.0

Yeah, this used to be necessary at some point, and then I ripped out that code and did not remove this.  Thanks for the fix.
Comment 3 Ed Morley [:emorley] 2012-05-30 07:40:37 PDT
https://hg.mozilla.org/mozilla-central/rev/8ffcc3efc77e

Note You need to log in before you can comment on or make changes to this bug.