stop console spamming by MSAA events

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

unspecified
mozilla15
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 627698 [details] [diff] [review]
patch
Attachment #627698 - Flags: review?(trev.saunders)
Comment on attachment 627698 [details] [diff] [review]
patch

Review of attachment 627698 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/Logging.h
@@ +20,5 @@
>  namespace mozilla {
>  namespace a11y {
>  namespace logging {
>  
>  enum EModules {

Why is this called EModules?

@@ +25,5 @@
>    eDocLoad = 1 << 0,
>    eDocCreate = 1 << 1,
>    eDocDestroy = 1 << 2,
> +  eDocLifeCycle = eDocLoad | eDocCreate | eDocDestroy,
> +  eMSAA = 1 << 3

Why not ePlatform?
(Assignee)

Comment 2

5 years ago
(In reply to David Bolter [:davidb] from comment #1)

> >  enum EModules {
> 
> Why is this called EModules?

sort of different modules inside a11y

> > +  eMSAA = 1 << 3
> 
> Why not ePlatform?

fine with me
OK thanks (f=me).
Comment on attachment 627698 [details] [diff] [review]
patch

I'm not sure grouping all msaa things or platform things together is the right module / logging group break up, but I don't see what it hurts to do it this way and changing should be easy if we decide to at some point.
Attachment #627698 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #4)
> I'm not sure grouping all msaa things or platform things together is the
> right module / logging group break up, but I don't see what it hurts to do
> it this way and changing should be easy if we decide to at some point.

I have the same feeling
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc775f973994
Target Milestone: --- → mozilla15

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/dc775f973994
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.