Closed Bug 759105 Opened 8 years ago Closed 8 years ago

stop console spamming by MSAA events

Categories

(Core :: Disability Access APIs, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #627698 - Flags: review?(trev.saunders)
Comment on attachment 627698 [details] [diff] [review]
patch

Review of attachment 627698 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/Logging.h
@@ +20,5 @@
>  namespace mozilla {
>  namespace a11y {
>  namespace logging {
>  
>  enum EModules {

Why is this called EModules?

@@ +25,5 @@
>    eDocLoad = 1 << 0,
>    eDocCreate = 1 << 1,
>    eDocDestroy = 1 << 2,
> +  eDocLifeCycle = eDocLoad | eDocCreate | eDocDestroy,
> +  eMSAA = 1 << 3

Why not ePlatform?
(In reply to David Bolter [:davidb] from comment #1)

> >  enum EModules {
> 
> Why is this called EModules?

sort of different modules inside a11y

> > +  eMSAA = 1 << 3
> 
> Why not ePlatform?

fine with me
Comment on attachment 627698 [details] [diff] [review]
patch

I'm not sure grouping all msaa things or platform things together is the right module / logging group break up, but I don't see what it hurts to do it this way and changing should be easy if we decide to at some point.
Attachment #627698 - Flags: review?(trev.saunders) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #4)
> I'm not sure grouping all msaa things or platform things together is the
> right module / logging group break up, but I don't see what it hurts to do
> it this way and changing should be easy if we decide to at some point.

I have the same feeling
https://hg.mozilla.org/mozilla-central/rev/dc775f973994
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.