Last Comment Bug 759105 - stop console spamming by MSAA events
: stop console spamming by MSAA events
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All Windows 7
: -- normal (vote)
: mozilla15
Assigned To: alexander :surkov
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-28 07:43 PDT by alexander :surkov
Modified: 2012-05-30 08:15 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.94 KB, patch)
2012-05-28 07:43 PDT, alexander :surkov
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-05-28 07:43:11 PDT
Created attachment 627698 [details] [diff] [review]
patch
Comment 1 David Bolter [:davidb] 2012-05-28 07:48:38 PDT
Comment on attachment 627698 [details] [diff] [review]
patch

Review of attachment 627698 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/Logging.h
@@ +20,5 @@
>  namespace mozilla {
>  namespace a11y {
>  namespace logging {
>  
>  enum EModules {

Why is this called EModules?

@@ +25,5 @@
>    eDocLoad = 1 << 0,
>    eDocCreate = 1 << 1,
>    eDocDestroy = 1 << 2,
> +  eDocLifeCycle = eDocLoad | eDocCreate | eDocDestroy,
> +  eMSAA = 1 << 3

Why not ePlatform?
Comment 2 alexander :surkov 2012-05-28 07:51:56 PDT
(In reply to David Bolter [:davidb] from comment #1)

> >  enum EModules {
> 
> Why is this called EModules?

sort of different modules inside a11y

> > +  eMSAA = 1 << 3
> 
> Why not ePlatform?

fine with me
Comment 3 David Bolter [:davidb] 2012-05-28 07:55:52 PDT
OK thanks (f=me).
Comment 4 Trevor Saunders (:tbsaunde) 2012-05-28 12:20:54 PDT
Comment on attachment 627698 [details] [diff] [review]
patch

I'm not sure grouping all msaa things or platform things together is the right module / logging group break up, but I don't see what it hurts to do it this way and changing should be easy if we decide to at some point.
Comment 5 alexander :surkov 2012-05-29 05:39:17 PDT
(In reply to Trevor Saunders (:tbsaunde) from comment #4)
> I'm not sure grouping all msaa things or platform things together is the
> right module / logging group break up, but I don't see what it hurts to do
> it this way and changing should be easy if we decide to at some point.

I have the same feeling
Comment 7 Ed Morley [:emorley] 2012-05-30 08:15:31 PDT
https://hg.mozilla.org/mozilla-central/rev/dc775f973994

Note You need to log in before you can comment on or make changes to this bug.