759115 - Bump minimum Android SDK API level we require to 14

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

When building with SDK 13, which is currently allowed, one gets the following build failure:

res/values-xlarge/themes.xml:17: error: Error: No resource found that matches the given name: attr 'android:actionBarDivider'.
res/values-sw600dp/themes.xml:17: error: Error: No resource found that matches the given name: attr 'android:actionBarDivider'.
make[6]: *** [R.java] Error 1

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bump minimum Android SDK API level we require to 14

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 627704 [details] [diff] [review]
Bump minimum Android SDK API level we require to 14

Review of attachment 627704 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't change our runtime compat requirements, just the version of the SDK we require, right?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted] from comment #2)
> This doesn't change our runtime compat requirements, just the version of the
> SDK we require, right?

Indeed.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/d8e75ef4e5ad

Comment 5

[Mike Hommey [:glandium]]

Backed out, we use android-13 for android XUL (and it's fine).
https://hg.mozilla.org/mozilla-central/rev/65fa5cb6f79c

Comment 6

[Mike Hommey [:glandium]]

Attachment: Move Android SDK/NDK checks in build/autoconf/android.m4, and bump minimum Android SDK API level we require to 14 for mobile/android

Mostly, this moves stuff around, and just adds a check on the target application to set the minimum android sdk api level accordingly.
https://tbpl.mozilla.org/?noignore=1&tree=Try&rev=7c9f4fa9c5a1

Comment 7

[Mike Hommey [:glandium]]

Attachment: Move Android SDK/NDK checks in build/autoconf/android.m4, and bump minimum Android SDK API level we require to 14 for mobile/android

Without the egg-info change (yay for egg-info in the tree).

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a78601d88586

Comment 9

[Mike Hommey [:glandium]]

Backed out because of B2G bustage
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e76fae10e5

Comment 10

[Mike Hommey [:glandium]]

Relanded with basic fixups
https://hg.mozilla.org/integration/mozilla-inbound/rev/a430a3d30163

Comment 11

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/a430a3d30163

Comment 12

[Alphat-PC]

Typo?

diff --git a/js/src/aclocal.m4 b/js/src/aclocal.m4
--- a/js/src/aclocal.m4
+++ b/js/src/aclocal.m4
@@ -17,6 +17,6 @@ builtin(include, build/autoconf/frameptr
 builtin(include, build/autoconf/compiler-opts.m4)dnl
 builtin(include, build/autoconf/expandlibs.m4)dnl
 builtin(include, build/autoconf/arch.m4)dnl
-builtin(include, build/autoconf/android.m4)dn
+builtin(include, build/autoconf/android.m4)dnl
 
 MOZ_PROG_CHECKMSYS()