The default bug view has changed. See this FAQ.

Bump minimum Android SDK API level we require to 14

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla16
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
When building with SDK 13, which is currently allowed, one gets the following build failure:

res/values-xlarge/themes.xml:17: error: Error: No resource found that matches the given name: attr 'android:actionBarDivider'.
res/values-sw600dp/themes.xml:17: error: Error: No resource found that matches the given name: attr 'android:actionBarDivider'.
make[6]: *** [R.java] Error 1
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 1

5 years ago
Created attachment 627704 [details] [diff] [review]
Bump minimum Android SDK API level we require to 14
Attachment #627704 - Flags: review?(ted.mielczarek)
Comment on attachment 627704 [details] [diff] [review]
Bump minimum Android SDK API level we require to 14

Review of attachment 627704 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't change our runtime compat requirements, just the version of the SDK we require, right?
Attachment #627704 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Ted Mielczarek [:ted] from comment #2)
> This doesn't change our runtime compat requirements, just the version of the
> SDK we require, right?

Indeed.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d8e75ef4e5ad
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(Assignee)

Comment 5

5 years ago
Backed out, we use android-13 for android XUL (and it's fine).
https://hg.mozilla.org/mozilla-central/rev/65fa5cb6f79c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

5 years ago
Created attachment 629715 [details] [diff] [review]
Move Android SDK/NDK checks in build/autoconf/android.m4, and bump minimum Android SDK API level we require to 14 for mobile/android

Mostly, this moves stuff around, and just adds a check on the target application to set the minimum android sdk api level accordingly.
https://tbpl.mozilla.org/?noignore=1&tree=Try&rev=7c9f4fa9c5a1
Attachment #629715 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Attachment #627704 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
Created attachment 629733 [details] [diff] [review]
Move Android SDK/NDK checks in build/autoconf/android.m4, and bump minimum Android SDK API level we require to 14 for mobile/android

Without the egg-info change (yay for egg-info in the tree).
Attachment #629733 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Attachment #629715 - Attachment is obsolete: true
Attachment #629715 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Attachment #627704 - Flags: review+
Attachment #629733 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a78601d88586
Target Milestone: mozilla15 → mozilla16
(Assignee)

Comment 9

5 years ago
Backed out because of B2G bustage
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e76fae10e5
(Assignee)

Comment 10

5 years ago
Relanded with basic fixups
https://hg.mozilla.org/integration/mozilla-inbound/rev/a430a3d30163
https://hg.mozilla.org/mozilla-central/rev/a430a3d30163
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Comment 12

5 years ago
Typo?

diff --git a/js/src/aclocal.m4 b/js/src/aclocal.m4
--- a/js/src/aclocal.m4
+++ b/js/src/aclocal.m4
@@ -17,6 +17,6 @@ builtin(include, build/autoconf/frameptr
 builtin(include, build/autoconf/compiler-opts.m4)dnl
 builtin(include, build/autoconf/expandlibs.m4)dnl
 builtin(include, build/autoconf/arch.m4)dnl
-builtin(include, build/autoconf/android.m4)dn
+builtin(include, build/autoconf/android.m4)dnl
 
 MOZ_PROG_CHECKMSYS()
Depends on: 765808
You need to log in before you can comment on or make changes to this bug.