759136 - Can't install paid app from review page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Andrew Williamson [:eviljeff]]

Steps to Reproduce:
1) go to review page for paid app pending review (e.g. the one in URL)
2) press coloured purchase button (that just says $0.99 in this case)

The console shows this error:
Error: TypeError: z.payments is undefined
Source File: https://marketplace-cdn.addons.mozilla.net/media/js/mkt/reviewers-min.js?build=3927a5e
Line: 3

The only workaround would be actually purchasing each app via the public page, which isn't a great solution.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/b0a3ee0

Caveat: If apps are do valid receipt checking, you'll be blocked by bug 755309 (we're not issuing valid receipts for paid apps if you're reviewing them from the Reviewer Tools). Andy's swooping in to fix this <3

Comment 2

[krupa raj[:krupa]]

Installing paid apps still doesn't work: https://marketplace-dev.allizom.org/en-US/reviewers/apps/review/communities?num=6

reopening

Comment 3

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/02b1e7d

Comment 4

[krupa raj[:krupa]]

verified fixed at https://marketplace-dev.allizom.org/en-US/reviewers/apps/review/chess?num=15

Comment 5

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Pushed to production on Tues, 5/29 @ 1:45 PM EDT. Check https://addons.mozilla.org/en-US/android/addon/phony/?src=search