759189 - Tree admin panel doesn't work when using baseURL to run TBPL locally (TypeError: invalid 'in' operand builder)

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1

Using the same rev as currently on tbpl.m.o (http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/cefda9fd4b40)

1) Open js/Config.js and change the baseURL to "https://tbpl.mozilla.org/"
2) Open index.html
3) From the 'Tree Info' menu, access the tree admin panel

Expected:
Spinner disappears after a few seconds and the list of builders appears.

Actual:
Perpetual spinner and the following in the error console...

> Error: TypeError: invalid 'in' operand builder
> Source File: file:///C:/mozilla/tbpl/js/HiddenBuildsAdminUI.js
> Line: 91

Comment 1

[Ed Morley [:emorley]]

Using the web console, HiddenBuildsAdminUI.js can be seen to be making the https://tbpl.mozilla.org/php/getBuilders.php?branch=<branch name> GET correctly & the response is identical to that when using the front-end from tbpl.m.o.

Also, the error doesn't occur in Chrome 21.0.1145.0 dev-m, with no errors or warnings shown in their console.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 656326 [details] [diff] [review]
patch

Seems reasonable to me.

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/ba6f749f4d78

Comment 5

[Ed Morley [:emorley]]

Thanks for sorting this :-)