Closed
Bug 759189
Opened 9 years ago
Closed 9 years ago
Tree admin panel doesn't work when using baseURL to run TBPL locally (TypeError: invalid 'in' operand builder)
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: mbrubeck)
References
Details
Attachments
(1 file)
937 bytes,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 Using the same rev as currently on tbpl.m.o (http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/cefda9fd4b40) 1) Open js/Config.js and change the baseURL to "https://tbpl.mozilla.org/" 2) Open index.html 3) From the 'Tree Info' menu, access the tree admin panel Expected: Spinner disappears after a few seconds and the list of builders appears. Actual: Perpetual spinner and the following in the error console... > Error: TypeError: invalid 'in' operand builder > Source File: file:///C:/mozilla/tbpl/js/HiddenBuildsAdminUI.js > Line: 91
Reporter | ||
Comment 1•9 years ago
|
||
Using the web console, HiddenBuildsAdminUI.js can be seen to be making the https://tbpl.mozilla.org/php/getBuilders.php?branch=<branch name> GET correctly & the response is identical to that when using the front-end from tbpl.m.o. Also, the error doesn't occur in Chrome 21.0.1145.0 dev-m, with no errors or warnings shown in their console.
Assignee | ||
Comment 2•9 years ago
|
||
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #656326 -
Flags: review?(philringnalda)
Comment 3•9 years ago
|
||
Comment on attachment 656326 [details] [diff] [review] patch Seems reasonable to me.
Attachment #656326 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/ba6f749f4d78
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Reporter | ||
Comment 5•9 years ago
|
||
Thanks for sorting this :-)
Updated•7 years ago
|
Product: Webtools → Tree Management
Updated•6 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•