759263 - virtualenv uses CFLAGS instead of HOST_CFLAGS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

It should use HOST_CFLAGS as well as a few other variables, probably (my patch addresses also CXXFLAGS and LDFLAGS). Setting them explicitly in Makefile seems to be the right fix.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=0a587e837079

Comment 1

[Jacek Caban]

I did try push based on wrong tree. Here is the right one (I will cancel previous builds):

https://tbpl.mozilla.org/?tree=Try&rev=7118a5c06fcc

Comment 2

[Marco Perez [:mpk]]

This patch improves the situation on FreeBSD, where the builds were broken by the "unified virtualenv" landing. There's still some "-L/usr/local/lib" missing to get things going again.
I doubt that it should be hard-coded into the Makefile, but I haven't found out what other variable could be added to fix that remaining issue.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 627882 [details] [diff] [review]
fix v1.0

Review of attachment 627882 [details] [diff] [review]:
-----------------------------------------------------------------

Bleh.

Comment 4

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87a43f124ee9

Comment 5

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/87a43f124ee9