Closed
Bug 759263
Opened 13 years ago
Closed 13 years ago
virtualenv uses CFLAGS instead of HOST_CFLAGS
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
813 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
It should use HOST_CFLAGS as well as a few other variables, probably (my patch addresses also CXXFLAGS and LDFLAGS). Setting them explicitly in Makefile seems to be the right fix.
Try push:
https://tbpl.mozilla.org/?tree=Try&rev=0a587e837079
Attachment #627882 -
Flags: review?(ted.mielczarek)
|
Assignee | |
Comment 1•13 years ago
|
||
I did try push based on wrong tree. Here is the right one (I will cancel previous builds):
https://tbpl.mozilla.org/?tree=Try&rev=7118a5c06fcc
|
||
Comment 2•13 years ago
|
||
This patch improves the situation on FreeBSD, where the builds were broken by the "unified virtualenv" landing. There's still some "-L/usr/local/lib" missing to get things going again.
I doubt that it should be hard-coded into the Makefile, but I haven't found out what other variable could be added to fix that remaining issue.
|
||
Comment 3•13 years ago
|
||
Comment on attachment 627882 [details] [diff] [review]
fix v1.0
Review of attachment 627882 [details] [diff] [review]:
-----------------------------------------------------------------
Bleh.
Attachment #627882 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → mozilla16
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•