virtualenv uses CFLAGS instead of HOST_CFLAGS

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla16
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 627882 [details] [diff] [review]
fix v1.0

It should use HOST_CFLAGS as well as a few other variables, probably (my patch addresses also CXXFLAGS and LDFLAGS). Setting them explicitly in Makefile seems to be the right fix.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=0a587e837079
Attachment #627882 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 1

5 years ago
I did try push based on wrong tree. Here is the right one (I will cancel previous builds):

https://tbpl.mozilla.org/?tree=Try&rev=7118a5c06fcc

Comment 2

5 years ago
This patch improves the situation on FreeBSD, where the builds were broken by the "unified virtualenv" landing. There's still some "-L/usr/local/lib" missing to get things going again.
I doubt that it should be hard-coded into the Makefile, but I haven't found out what other variable could be added to fix that remaining issue.
Comment on attachment 627882 [details] [diff] [review]
fix v1.0

Review of attachment 627882 [details] [diff] [review]:
-----------------------------------------------------------------

Bleh.
Attachment #627882 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/87a43f124ee9
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/87a43f124ee9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.