Last Comment Bug 759282 - Location bar should have the same horizontal spacing between the icon and text as the autocomplete popup
: Location bar should have the same horizontal spacing between the icon and tex...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows XP
: -- trivial (vote)
: Firefox 15
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-29 04:20 PDT by Dão Gottwald [:dao]
Modified: 2012-05-31 06:15 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (805 bytes, patch)
2012-05-29 04:20 PDT, Dão Gottwald [:dao]
no flags Details | Diff | Splinter Review
patch v2 (1.14 KB, patch)
2012-05-30 02:28 PDT, Dão Gottwald [:dao]
jaws: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-05-29 04:20:31 PDT
Created attachment 627908 [details] [diff] [review]
patch

Currently, the text in the location bar is indented slightly more than in the autocomplete popup.
Comment 1 Dão Gottwald [:dao] 2012-05-29 04:28:18 PDT
Comment on attachment 627908 [details] [diff] [review]
patch

This doesn't fix it when the back button isn't connected to the location bar. Needs more adjustments to work consistently.
Comment 2 Dão Gottwald [:dao] 2012-05-30 02:28:01 PDT
Created attachment 628279 [details] [diff] [review]
patch v2
Comment 3 Jared Wein [:jaws] (please needinfo? me) 2012-05-30 06:20:16 PDT
Comment on attachment 628279 [details] [diff] [review]
patch v2

Are you planning on fixing this for pinstripe and gnomestripe? Or do those themes not have this same issue?
Comment 4 Dão Gottwald [:dao] 2012-05-30 06:21:00 PDT
gnomestripe doesn't have it, I haven't checked pinstripe.
Comment 5 Jared Wein [:jaws] (please needinfo? me) 2012-05-30 06:52:39 PDT
I can check on pinstripe today.
Comment 6 Dão Gottwald [:dao] 2012-05-30 07:56:49 PDT
(In reply to Jared Wein [:jaws] from comment #5)
> I can check on pinstripe today.

Thanks. I'll land this now. Please clone this bug for OS X if needed.
Comment 8 Ed Morley [:emorley] 2012-05-31 06:15:15 PDT
https://hg.mozilla.org/mozilla-central/rev/be6973c48222

Note You need to log in before you can comment on or make changes to this bug.