759311 - Assertions in update tests have to be more verbose

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There are a couple of instances in the current test and lib code which make use of the old controller.assert() method. All of those have to be converted to use the assertions module. Otherwise it's kinda hard to figure out the reason for all the latest update test failures for localized builds.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 627931 [details] [diff] [review]
Patch v1

Looks good. I just have one general question regarding the following line:

expect.equal(button.getNode().hidden, false, "The update button is always visible even after an update.");

An alternative would be to use:

expect.ok(!button.getNode().hidden, "The update button is always visible even after an update.");

When checking something is false would we always use the former, or would there be times we'd use the latter?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Dave Hunt (:davehunt) from comment #2)
> An alternative would be to use:
> 
> expect.ok(!button.getNode().hidden, "The update button is always visible
> even after an update.");

Sorry, that's the right way to do it. Simply missed it to use ok(). Thanks for the catch.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/57f0c818570e

Once it has been proven to work, I will backport the patch to older branches.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on other branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/cbc33a9b8eb9 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/48968257b080 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/44f081aa84a0 (esr10)