There are a couple of instances in the current test and lib code which make use of the old controller.assert() method. All of those have to be converted to use the assertions module. Otherwise it's kinda hard to figure out the reason for all the latest update test failures for localized builds.
Created attachment 627931 [details] [diff] [review]
Comment on attachment 627931 [details] [diff] [review]
Looks good. I just have one general question regarding the following line:
expect.equal(button.getNode().hidden, false, "The update button is always visible even after an update.");
An alternative would be to use:
expect.ok(!button.getNode().hidden, "The update button is always visible even after an update.");
When checking something is false would we always use the former, or would there be times we'd use the latter?
(In reply to Dave Hunt (:davehunt) from comment #2)
> An alternative would be to use:
> expect.ok(!button.getNode().hidden, "The update button is always visible
> even after an update.");
Sorry, that's the right way to do it. Simply missed it to use ok(). Thanks for the catch.
Once it has been proven to work, I will backport the patch to older branches.
Landed on other branches: