The default bug view has changed. See this FAQ.

Assertions in update tests have to be more verbose

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

unspecified

Firefox Tracking Flags

(firefox12 unaffected, firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox-esr10 fixed, status1.9.2 wontfix)

Details

(Whiteboard: [lib][qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There are a couple of instances in the current test and lib code which make use of the old controller.assert() method. All of those have to be converted to use the assertions module. Otherwise it's kinda hard to figure out the reason for all the latest update test failures for localized builds.
(Assignee)

Updated

5 years ago
Whiteboard: [lib]
(Assignee)

Comment 1

5 years ago
Created attachment 627931 [details] [diff] [review]
Patch v1
Attachment #627931 - Flags: review?(dave.hunt)
Comment on attachment 627931 [details] [diff] [review]
Patch v1

Looks good. I just have one general question regarding the following line:

expect.equal(button.getNode().hidden, false, "The update button is always visible even after an update.");

An alternative would be to use:

expect.ok(!button.getNode().hidden, "The update button is always visible even after an update.");

When checking something is false would we always use the former, or would there be times we'd use the latter?
Attachment #627931 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Dave Hunt (:davehunt) from comment #2)
> An alternative would be to use:
> 
> expect.ok(!button.getNode().hidden, "The update button is always visible
> even after an update.");

Sorry, that's the right way to do it. Simply missed it to use ok(). Thanks for the catch.
(Assignee)

Comment 4

5 years ago
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/57f0c818570e

Once it has been proven to work, I will backport the patch to older branches.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status1.9.2: --- → wontfix
status-firefox-esr10: --- → affected
status-firefox12: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Landed on other branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/cbc33a9b8eb9 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/48968257b080 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/44f081aa84a0 (esr10)
status-firefox-esr10: affected → fixed
status-firefox12: affected → unaffected
status-firefox13: affected → fixed
status-firefox14: affected → fixed
Whiteboard: [lib] → [lib][qa-]
You need to log in before you can comment on or make changes to this bug.