759338 - crash in java.util.concurrent.RejectedExecutionException: pool=128/128, queue=10/10 at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:1961)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This bug was filed from the Socorro interface and is 
report bp-e8583333-6fd8-4466-b68e-f339d2120529 .
https://crash-stats.mozilla.com/report/index/bp-e8583333-6fd8-4466-b68e-f339d2120529
============================================================= 

java.util.concurrent.RejectedExecutionException: pool=128/128, queue=10/10
	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:1961)
	at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:794)
	at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1315)
	at android.os.AsyncTask.execute(AsyncTask.java:394)
	at org.mozilla.gecko.AwesomeBarTabs$HistoryQueryTask$1.onChange(AwesomeBarTabs.java:558)
	at android.database.ContentObserver$NotificationRunnable.run(ContentObserver.java:43)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:123)
	at org.mozilla.gecko.GeckoBackgroundThread.run(GeckoBackgroundThread.java:31)

Crash occurred while migrating profile : http://people.mozilla.com/~nhirata/Profiles/largehistory.zip and looking at the history pages

[w/ rnewman's build]

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Probably more stuff triggering on changes to the history DB and posting AsyncTasks whenever something happens. Maybe similar to

https://bugzilla.mozilla.org/show_bug.cgi?id=726379

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat

Logcat of testing; grepping "history" shows : 05-29 09:13:32.685 W/FennecControlHelper( 4587): Caught exception checking if Fennec has migrated column ensure_history_migrated.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

We're seeing a bunch of these crashes traced back to Sync. e.g. bp-29dbc7c7-6c34-459d-8f8e-9601e0180307

> at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2049)
> at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:814)
> at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1360)
> at java.util.concurrent.Executors$DelegatedExecutorService.execute(Executors.java:591)
> at org.mozilla.gecko.sync.repositories.uploaders.PayloadDispatcher.queue(PayloadDispatcher.java:56)
> at org.mozilla.gecko.sync.repositories.uploaders.BatchingUploader.flush(BatchingUploader.java:304)
> at org.mozilla.gecko.sync.repositories.uploaders.BatchingUploader.noMoreRecordsToUpload(BatchingUploader.java:228)
> at org.mozilla.gecko.sync.repositories.Server15RepositorySession.storeDone(Server15RepositorySession.java:109)
> at org.mozilla.gecko.sync.middleware.MiddlewareRepositorySession.storeDone(MiddlewareRepositorySession.java:111)
> at org.mozilla.gecko.sync.synchronizer.RecordsChannel.onFetchCompleted(RecordsChannel.java:236)
> at org.mozilla.gecko.sync.repositories.android.FormHistoryRepositorySession$1.run(FormHistoryRepositorySession.java:216)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
> at java.lang.Thread.run(Thread.java:761)

Grisha, is this something you can look into?

Comment 4

[:Grisha Kruglov]

Looking into this.

Comment 5

[:Grisha Kruglov]

From the crash reports, there are multiple bugs involved here, and only one seems to be related to sync. I've split that work off into Bug 1445462.

Comment 6

[Jan Henning [:JanH]]

Attempting to upgrade to v26.1.0 of the support library seems to make a similar problem appear in automation as well:
https://bugzilla.mozilla.org/show_bug.cgi?id=1385464#c3

Comment 7

[Levente Sacal]

One crash when browsing on Nightly 65.0a1 (2018-11-08) when browsing on https://diego-romania.ro/covor/covoare-moderne/art-covor-fiber-20773110

Comment 8

[Jan Henning [:JanH]]

A link to the crash report would have been nice.

Comment 9

[Levente Sacal]

Sorry about that. https://crash-stats.mozilla.com/report/index/f2e27bea-532c-489b-ad36-ce4780181109

Comment 10

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

This is a fairly high volume crash on release 63, we should investigate.

Comment 11

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Calling this P2 now since the crash volume is not as high on release 64 as it was in 63.

Comment 12

[Marcia Knous [:marcia]]

https://bit.ly/2CNk028 is the only signature that is still active in recent builds. A few of the comments mention video crashes. No specific pattern to the URLs, which run the gamut from Facebook to GMail.

Here is some correlation information:

(95.03% in signature vs 20.77% overall) moz_crash_reason = MOZ_CRASH(Uncaught Java exception)
(04.97% in signature vs 63.46% overall) moz_crash_reason = null
(94.24% in signature vs 39.66% overall) address = 0x0
(48.95% in signature vs 13.85% overall) Module "signons.sqlite-shm" = true
(94.24% in signature vs 62.45% overall) reason = SIGSEGV /SEGV_MAPERR
(42.93% in signature vs 10.01% overall) Module "formhistory.sqlite-shm" = true
(61.78% in signature vs 33.59% overall) Module "browser.db (deleted)" = true [65.37% vs 38.65% if platform = Android]

LG-M150 is the top crashing device, but there is a fairly wide spectrum of devices including Pixel, Pixel 2 and Pixel 3.

Comment 13

[Marian Heiner]

One crash when browsing on Nightly 65.0a1 when browsing on https://epardoseli.ro/Produse/gresie-tip-parchet/

Comment 14

[Flavius Stica]

Have some crash with 69.0.2 on https://blugi-barbati.ro/listing-category/blugi-barbati-ieftini/
Try to update to 70.0 but have some errors!

Comment 15

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.

Comment 16

[Marian Heiner]

One crash when browsing on Nightly 65.0a1 when browsing on https://organicsfood.ro/sanatate-nutritie-fitness/