759341 - Unable to view crash queries and bugs in advanced search and top crashers with a signature containing /

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Scoobidiver (away)]

For crash queries with signatures containing /, there's a bad error message. See https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=ALL%3AALL&range_value=1&range_unit=weeks&query_search=signature&query_type=contains&query=%2F&do_query=1

Comment 1

[Scoobidiver (away)]

The advanced search stops also bug matchings after the first signature containing /. See https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=FennecAndroid%3A14.0b3&range_value=1&range_unit=weeks&query_search=signature&query_type=contains&do_query=1

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/626

Steps to QA
-----------

1. Go to advanced search and search for anything containing a slash in the signature (preferably in FennecAndroid, there might be some results there)
2. Click a signature to go to report/list and verify that it doesn't show any error

Comment 4

[Robert Kaiser]

Can you test if this fixes bug 759784 as well?

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

@KaiRo: it doesn't, bug 759784 is an entirely different problem.

Comment 6

[[github robot]]

Commits pushed to admin-refactor at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/97a55d9e1940446644c79ba459393fe375e92b9e
Fixes bug 759341 - Double encode signature in URL for signature_urls page.

https://github.com/mozilla/socorro/commit/8794be2eca229950b282321c1d9aab50096964af
Merge pull request #626 from AdrianGaudebert/759341-fix-slash-in-signature-urls

Fixes bug 759341 - Double encode signature in URL for signature_urls page.

Comment 7

[Matt Brandt [:mbrandt]]

Thanks adrian: QA verified on stage per the comments in comment 0, comment 1, and comment 3.

Automation also ran and passed - basic search functionality is still behaving as it did before adrian's code landed.


example:
https://crash-stats.allizom.org/query/query?product=FennecAndroid&version=ALL%3AALL&range_value=1&range_unit=weeks&date=06%2F01%2F2012+20%3A55%3A20&query_search=signature&query_type=contains&query=java.util.concurrent.RejectedExecutionException%3A+pool%3D1%2F1%2C+queue%3D0+at+java.util.concurrent.ThreadPoolExecutor%24AbortPolicy.rejectedExecution%28ThreadPoolExecutor.java%29+&reason=&build_id=&process_type=any&hang_type=any&do_query=1

Comment 8

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0089c6652cee016fa1dc597c4c2e0ba9a7b22007
Fixes bug 759341 - Double encode signature in URL for signature_urls page.

Comment 9

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0089c6652cee016fa1dc597c4c2e0ba9a7b22007
Fixes bug 759341 - Double encode signature in URL for signature_urls page.