Closed
Bug 759434
Opened 13 years ago
Closed 13 years ago
floor_div is unused
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
DUPLICATE
of bug 797604
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #628038 -
Flags: review?(jones.chris.g)
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
|
||
Comment 1•13 years ago
|
||
That function is used below.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Ah, you are right.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•13 years ago
|
Attachment #628038 -
Flags: review?(jones.chris.g)
|
||
Comment 3•13 years ago
|
||
clang warns about this, and I think the warning is kind of right. Every time the header is included and the template is not instantiated, the function is unused. I assume the compiler would not output the function in each translation unit that includes TiledLayerBuffer.h but I don't know. I think floor_div should be marked inline (which would silence the warning) or changed to be a private static function on TiledLayerBuffer.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
|
|
||
Updated•13 years ago
|
Blocks: buildwarning
|
||
Updated•13 years ago
|
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → DUPLICATE
|
|
||
Comment 5•13 years ago
|
||
I think it's worth actually silencing this warning instead of having other waste time on this.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
|
||
Comment 6•13 years ago
|
||
Opps, the fix is actually in bug 797604. Carry on :)
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•