Closed Bug 759449 Opened 12 years ago Closed 12 years ago

Change UI lag telemetry to an EXPONENTIAL histogram

Categories

(Toolkit :: Telemetry, defect)

12 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Patch v1. (obsolete) — Splinter Review
In Bug 710935 we measure UI lag when it is > 50ms. We initially did this with 200 buckets spanning 30ms. It would be good to increase that range to be higher than 30s and also to use an exponential distribution of buckets instead.
Attachment #628050 - Flags: review?(taras.mozilla)
*spanning 30s
Comment on attachment 628050 [details] [diff] [review]
Patch v1.

Do we really care about lag over 30s?
Attachment #628050 - Flags: review?(taras.mozilla) → review+
Comment on attachment 628050 [details] [diff] [review]
Patch v1.

Also please move (ms) to the tail of the comment. This will eventually get enforced by the build system.
> Do we really care about lag over 30s?

Maybe not but this will only take 1 of the 20 buckets so might as well.
Attachment #628050 - Attachment is obsolete: true
Attachment #628093 - Flags: review+
oops you said comment not name, sec updating again.
Attachment #628093 - Attachment is obsolete: true
Attachment #628095 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/4c68e77d89d8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: