Last Comment Bug 759459 - Build broken on FreeBSD since patch for bug #745034 landed
: Build broken on FreeBSD since patch for bug #745034 landed
Status: RESOLVED FIXED
[js:p1:fx15]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All FreeBSD
: -- minor (vote)
: mozilla16
Assigned To: Marco Perez
:
Mentors:
Depends on:
Blocks: 745034
  Show dependency treegraph
 
Reported: 2012-05-29 12:23 PDT by Marco Perez
Modified: 2012-06-09 19:38 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
build log snippet (5.99 KB, text/plain)
2012-05-29 12:23 PDT, Marco Perez
no flags Details
unbreak the build (including unistd.h a bit later) (648 bytes, patch)
2012-05-29 12:27 PDT, Marco Perez
terrence: review+
Details | Diff | Review

Description Marco Perez 2012-05-29 12:23:21 PDT
Created attachment 628056 [details]
build log snippet

Unfortunately the aforementioned patch broke the builds on FreeBSD.
I'll attach a small patch shortly.
Comment 1 Marco Perez 2012-05-29 12:27:00 PDT
Created attachment 628057 [details] [diff] [review]
unbreak the build (including unistd.h a bit later)

Moving "#include <unistd.h>" down after "#include <sys/time.h>" fixed things for me. Comparing the include section with the ones in the following files, the patch seems pretty safe.
 ipc/chromium/src/base/process_util_posix.cc
 ipc/chromium/src/third_party/libevent/devpoll.c
 ipc/chromium/src/third_party/libevent/epoll.c
 ipc/chromium/src/third_party/libevent/http.c
 ipc/chromium/src/third_party/libevent/test/bench.c
Comment 2 Terrence Cole [:terrence] 2012-05-29 14:00:43 PDT
Comment on attachment 628057 [details] [diff] [review]
unbreak the build (including unistd.h a bit later)

Review of attachment 628057 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.  Looks fine to me.
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-06-09 09:26:19 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c88602e44a5b
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-06-09 19:38:43 PDT
https://hg.mozilla.org/mozilla-central/rev/c88602e44a5b

Note You need to log in before you can comment on or make changes to this bug.