Build broken on FreeBSD since patch for bug #745034 landed

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Marco Perez, Assigned: Marco Perez)

Tracking

Trunk
mozilla16
All
FreeBSD
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:p1:fx15])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 628056 [details]
build log snippet

Unfortunately the aforementioned patch broke the builds on FreeBSD.
I'll attach a small patch shortly.
(Assignee)

Comment 1

5 years ago
Created attachment 628057 [details] [diff] [review]
unbreak the build (including unistd.h a bit later)

Moving "#include <unistd.h>" down after "#include <sys/time.h>" fixed things for me. Comparing the include section with the ones in the following files, the patch seems pretty safe.
 ipc/chromium/src/base/process_util_posix.cc
 ipc/chromium/src/third_party/libevent/devpoll.c
 ipc/chromium/src/third_party/libevent/epoll.c
 ipc/chromium/src/third_party/libevent/http.c
 ipc/chromium/src/third_party/libevent/test/bench.c
Attachment #628057 - Flags: review?(terrence)
Whiteboard: [js:p1:fx15]
Comment on attachment 628057 [details] [diff] [review]
unbreak the build (including unistd.h a bit later)

Review of attachment 628057 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.  Looks fine to me.
Attachment #628057 - Flags: review?(terrence) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c88602e44a5b
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/c88602e44a5b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.