759459 - Build broken on FreeBSD since patch for bug #745034 landed

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Marco Perez [:mpk]]

Attachment: build log snippet

Unfortunately the aforementioned patch broke the builds on FreeBSD.
I'll attach a small patch shortly.

Comment 1

[Marco Perez [:mpk]]

Attachment: unbreak the build (including unistd.h a bit later)

Moving "#include <unistd.h>" down after "#include <sys/time.h>" fixed things for me. Comparing the include section with the ones in the following files, the patch seems pretty safe.
 ipc/chromium/src/base/process_util_posix.cc
 ipc/chromium/src/third_party/libevent/devpoll.c
 ipc/chromium/src/third_party/libevent/epoll.c
 ipc/chromium/src/third_party/libevent/http.c
 ipc/chromium/src/third_party/libevent/test/bench.c

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 628057 [details] [diff] [review]
unbreak the build (including unistd.h a bit later)

Review of attachment 628057 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.  Looks fine to me.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c88602e44a5b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c88602e44a5b