Closed Bug 759641 Opened 8 years ago Closed 8 years ago

small clean up of a11y logging

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
1) provide MsgBeing/End to allow logging without helper function like DocDestroy()
2) turn stacks logging into option
Attachment #628211 - Flags: review?(trev.saunders)
Assignee: nobody → surkov.alexander
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 628211 [details] [diff] [review]
patch

>+  vfprintf(stdout, aMsgText, argptr);

nit, why not use vprintf()?

>+ * Log the message ('title: text' format) on new line. Print the start and end
>+ * boundaries of the message body designed by '{' and '}' (2 spaces indent for

nit, designated by?
Attachment #628211 - Flags: review?(trev.saunders) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> >+  vfprintf(stdout, aMsgText, argptr);
> 
> nit, why not use vprintf()?

ok
https://hg.mozilla.org/mozilla-central/rev/9a6e690f779f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.