Last Comment Bug 759641 - small clean up of a11y logging
: small clean up of a11y logging
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: alexander :surkov
:
: alexander :surkov
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-29 21:42 PDT by alexander :surkov
Modified: 2012-06-02 11:42 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (11.84 KB, patch)
2012-05-29 21:42 PDT, alexander :surkov
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-05-29 21:42:28 PDT
Created attachment 628211 [details] [diff] [review]
patch

1) provide MsgBeing/End to allow logging without helper function like DocDestroy()
2) turn stacks logging into option
Comment 1 Trevor Saunders (:tbsaunde) 2012-05-31 12:41:55 PDT
Comment on attachment 628211 [details] [diff] [review]
patch

>+  vfprintf(stdout, aMsgText, argptr);

nit, why not use vprintf()?

>+ * Log the message ('title: text' format) on new line. Print the start and end
>+ * boundaries of the message body designed by '{' and '}' (2 spaces indent for

nit, designated by?
Comment 2 alexander :surkov 2012-05-31 19:14:57 PDT
(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> >+  vfprintf(stdout, aMsgText, argptr);
> 
> nit, why not use vprintf()?

ok

Note You need to log in before you can comment on or make changes to this bug.